* Improving the quality of Python packages
@ 2021-04-09 17:08 Ricardo Wurmus
2021-04-11 7:37 ` Lars-Dominik Braun
0 siblings, 1 reply; 3+ messages in thread
From: Ricardo Wurmus @ 2021-04-09 17:08 UTC (permalink / raw)
To: guix-devel
Hi there,
I just took it upon myself to upgrade our Jupyter / Python notebook
packages. Some of these packages have their tests disabled because of
circular dependencies. Unfortunately, when tests are disabled many
Python packages build fine even though they miss inputs.
Only when I enable tests Python complains about missing dependencies.
Is there a way we can improve the quality of those Python packages that
have tests disabled? I’d like to gain more confidence in these packages
and be sure that at least all dependencies are among the inputs.
--
Ricardo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Improving the quality of Python packages
2021-04-09 17:08 Improving the quality of Python packages Ricardo Wurmus
@ 2021-04-11 7:37 ` Lars-Dominik Braun
2021-04-11 18:32 ` Ricardo Wurmus
0 siblings, 1 reply; 3+ messages in thread
From: Lars-Dominik Braun @ 2021-04-11 7:37 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel
Hi Ricardo,
> Is there a way we can improve the quality of those Python packages that
> have tests disabled? I’d like to gain more confidence in these packages
> and be sure that at least all dependencies are among the inputs.
there is a new sanity check phase on core-updates, which should solve
this problem. See 09448c0994390697e876db235a3b773311795238.
Cheers,
Lars
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Improving the quality of Python packages
2021-04-11 7:37 ` Lars-Dominik Braun
@ 2021-04-11 18:32 ` Ricardo Wurmus
0 siblings, 0 replies; 3+ messages in thread
From: Ricardo Wurmus @ 2021-04-11 18:32 UTC (permalink / raw)
To: Lars-Dominik Braun; +Cc: guix-devel
Lars-Dominik Braun <lars@6xq.net> writes:
> Hi Ricardo,
>
>> Is there a way we can improve the quality of those Python packages that
>> have tests disabled? I’d like to gain more confidence in these packages
>> and be sure that at least all dependencies are among the inputs.
> there is a new sanity check phase on core-updates, which should solve
> this problem. See 09448c0994390697e876db235a3b773311795238.
Wonderful! That’s pretty much what I hoped for. I remember the patch
set now; thanks for reminding me!
--
Ricardo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-11 18:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 17:08 Improving the quality of Python packages Ricardo Wurmus
2021-04-11 7:37 ` Lars-Dominik Braun
2021-04-11 18:32 ` Ricardo Wurmus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).