From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GBluGqKDUmF5TwEAgWs5BA (envelope-from ) for ; Tue, 28 Sep 2021 04:53:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wHMfFqKDUmGmKgAAB5/wlQ (envelope-from ) for ; Tue, 28 Sep 2021 02:53:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 24DB130F19 for ; Tue, 28 Sep 2021 04:53:22 +0200 (CEST) Received: from localhost ([::1]:55450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mV3FB-0001fd-1X for larch@yhetil.org; Mon, 27 Sep 2021 22:53:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36142) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mV3Ey-0001cd-Nf for guix-devel@gnu.org; Mon, 27 Sep 2021 22:53:08 -0400 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]:33446) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mV3Ew-0008NL-Qy for guix-devel@gnu.org; Mon, 27 Sep 2021 22:53:08 -0400 Received: by mail-io1-xd2d.google.com with SMTP id n71so25546261iod.0 for ; Mon, 27 Sep 2021 19:53:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=x8pY42wEdnmmAxxchiEVZJN0/6XM+DSLkzJ5/JuByOo=; b=MUCbDm6jdEuZIdrGCuxxMUbTzQOP96+WEmZn2jte068A30dSVdEroqZBidRV0l46iF 0ruU4lyCD46GbgIhULbTC1n6ZXU34hNDXRaFhHscCcxVd71VWWqk6zVWU08Y5FWk3Vx8 ER9L+T6I8rv/CWyt1HwvhHV+cEXaYusd7BtvFhthuAqKkzQ/60GbdS6GRXXWCwPZlHWn rLZaOgNzEXbJUkuAM+loyALmki26m6fG9zfph0MA64H5t0TJ2fLa0DjHN4Nup5jbnzwN z3i3QZtACFy6ey9gbL9mvJa3ruilFY7X2H5FbmosaUyLbb6D6cXCK9oXb8UEZBsWNqBv Ts/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=x8pY42wEdnmmAxxchiEVZJN0/6XM+DSLkzJ5/JuByOo=; b=eOaNwU8N8OqMCnVa1y3UG0W7d20Arcybcm3sMAaLFHp7/lzqFCSnWn46GymbLSr3oD sLtFkl2UOPgtxSa6DnMcOMUvMPg1pWQXWRGOXYvJs1j+RJBuYUZDSM529RR/t6RRWJdC Cm8oP4xle5f96qqb6zX2DqRsOlKJuSRzhxRZ+5D7kS1xGXMDR7Q4BWP5S8A1Zj5AcWF9 kJ+bJzBluk5e5rmPiXRXRvtfuunobhuAvRvufnsB4yLyC6/k0nQE9DtGLuk0K2dC5Bqo rBmwjht0zBw7ZfgmsgW9ks311g/9CSs9GCoSHmHhT5LaORdZsERCmBdEfOboGAsZyCiR H76w== X-Gm-Message-State: AOAM530+E6lZELvGUFv9ycx+ZyTmBpf5WYpXvVmcRHEixy4yXY+MLv2P o80uUOLb6+ifKuEamFUFaa4dT60kSp0tYg== X-Google-Smtp-Source: ABdhPJyn+DqPzA6oytBMmNH5GL4rP64gU6dXtBrvbLY5792Dcj3beWvpUUwXdfGz/XzU26PhCfTD6w== X-Received: by 2002:a5d:8557:: with SMTP id b23mr2180597ios.192.1632797585688; Mon, 27 Sep 2021 19:53:05 -0700 (PDT) Received: from washu-v4 (172-221-246-205.res.spectrum.com. [172.221.246.205]) by smtp.gmail.com with ESMTPSA id w3sm10224647ilv.47.2021.09.27.19.53.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 19:53:05 -0700 (PDT) From: Katherine Cox-Buday To: Jack Hill Subject: Re: Go importer and packages with version flags References: Date: Mon, 27 Sep 2021 21:53:04 -0500 In-Reply-To: (Jack Hill's message of "Mon, 27 Sep 2021 17:51:35 -0400 (EDT)") Message-ID: <87ee99qulr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::d2d; envelope-from=cox.katherine.e@gmail.com; helo=mail-io1-xd2d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632797602; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=x8pY42wEdnmmAxxchiEVZJN0/6XM+DSLkzJ5/JuByOo=; b=gM3nY9zFSh7f8uT68Rd6St/nO4UjZKElGqe8tXhw9Zpzn971jjfIsVxDG1W0Q83esa6u+m VM2yyMk/RZwxpbvrTDF0+vvIuBaKjSokfCQKd3oC/G5IPAJF0T76fSoQHX6nWLYxgEfhib 3wSCdwotcaNhe8a/f01ZeiOa9wfdxlvKwI3s1fcYPlP10Xgiv9Kf9JcHRJm33yCdWnCki0 opN2oawI+tOMnWHYkngpwH9NnqexbUYfQxmCc45lJgBNgkFLVqW7KvIUtuQwgd6yeoEEwy XuvBswlhx4uCXCKYI2J6C0NnMnmL/osCUKDRJBvqCDPO8Yr96EJ8ANyDpDRE6w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632797602; a=rsa-sha256; cv=none; b=tQ1UMLNaLToaHRsRXh6bbbnkYuR2NbeAp3DUO6jEYvpeBWKX7HRImnz5GeK2e7XHBd2YG4 krBuWZZpoisE+8X94mfb0kX33yj+nunQ5eY7GXEAq25Bx/CsHr9io3AQc232cjCqcoufLu iUoZsP+ZUItEZFIRQkWmdr7BNfoL7hQV4TGzZi9BLVtxyXbPRkDobCfxAMh6o4nIGj6oYT 1N0ZcVmcS9hQWn9hAzPmhRW3fAibPpnpcOa3Q3SAq6hXzLfV3apnFodR975qclpIlLDxLP dfrHZAwXrImQq+Oi/G7vGff4wdIgA3+swZVZbEdvHTM3IHSiYoIB+RXR6EgwQg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=MUCbDm6j; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -3.09 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=MUCbDm6j; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 24DB130F19 X-Spam-Score: -3.09 X-Migadu-Scanner: scn0.migadu.com X-TUID: vBPSiRK7CBxM Jack Hill writes: > Hi Guix, Hey, Jack, a few thoughts. > While I was was working with the go importer today, it suggested I package > go-github-com-russross-blackfriday-v2. Fair enough, except we already have a > package for go-github-com-russross-blackfriday. I was poking around a rust code-base the other day and I noticed our crate importer, and thus a lot of crate packages, have major-version suffixes. I think one of the unique benefits of Guix is that it can simultaneously have multiple versions of libraries installed, and I think we should allow this for library packages. I know that leads to dependency graph explosion, but perhaps we only commit to substitutes for the latest version, and thus any packages using old versions. It should converge over time unless packages go unmaintained. I thought our current stance was to only allow one version at a time, but the crate packages made me question this. I'd like clarity too. > The packages differ in their version (2.1.0 verses 2.0.1), their imputs (the > imported package definition is missing the inputs and native-inputs that we > have in the Guix package), and the presense of the v2 versioning > disambiguation tag. The importer suggested package is correct. It looks like the listed dependencies dropped >= v1.5. See: - https://pkg.go.dev/github.com/russross/blackfriday@v2.0.0+incompatible?tab=imports vs - https://pkg.go.dev/github.com/russross/blackfriday/v2?tab=imports I wasn't sure if pkg.go listed test dependencies, so I ran this command to be sure: #+begin_example $ go list -deps -test -f '{{.ImportPath}} {{.Standard}}' |awk '{if ($2 == "false") print $1}' github.com/russross/blackfriday/v2 github.com/russross/blackfriday/v2.test #+end_example I think those were just dependencies incorrectly carried over as the package changed. I hope that helps. -- Katherine