From: "Ludovic Courtès" <ludo@gnu.org>
To: Marius Bakke <marius@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: Dealing with non-ASCII file names in BOOTSTRAP-ORIGIN
Date: Thu, 21 Jul 2022 17:02:13 +0200 [thread overview]
Message-ID: <87edyeldai.fsf@gnu.org> (raw)
In-Reply-To: <87bktmnref.fsf@gnu.org> (Marius Bakke's message of "Mon, 18 Jul 2022 21:37:44 +0200")
Hi!
Marius Bakke <marius@gnu.org> skribis:
> I tried switching to GCC 11 on the core-updates branch, but it fails
> early when attempting to repack the GCC source code for GCC-BOOT0,
> because some files in its test suite contains non-ASCII characters:
>
> [... unpacking ...]
> patching file gcc/builtins.c
> Hunk #1 succeeded at 4623 with fuzz 1 (offset 1341 lines).
> Hunk #2 succeeded at 6097 with fuzz 2 (offset 2206 lines).
> patching file gcc/gimple-fold.c
> Hunk #1 succeeded at 665 (offset 9 lines).
> Hunk #2 succeeded at 766 with fuzz 2 (offset 16 lines).
> patching file libvtv/Makefile.in
> Hunk #1 succeeded at 14 with fuzz 1 (offset -1 lines).
> source is at 'gcc-11.3.0'
> applying '/gnu/store/g0ba4l825z9i4l1jd5cqvl6m09xicdwa-gcc-9-strmov-store-file-names.patch'...
> applying '/gnu/store/5705r4ajxl8lav1hz9xm19w75zdcz1n2-gcc-5.0-libvtv-runpath.patch'...
> find-files: gcc-11.3.0/gcc/testsuite/go.test/test/fixedbugs/issue27836.dir/Äfoo.go: No such file or directory
> Backtrace:
> In srfi/srfi-1.scm:
> 465: 19 [fold #<procedure 143cb10 at ice-9/ftw.scm:451:38 (subdir result+visited)> ...]
> In ice-9/ftw.scm:
> 452: 18 [#<procedure 143cb10 at ice-9/ftw.scm:451:38 (subdir result+visited)> # #]
> 450: 17 [loop "gcc" "gcc-11.3.0" ...]
> In srfi/srfi-1.scm:
> 465: 16 [fold #<procedure 2375210 at ice-9/ftw.scm:451:38 (subdir result+visited)> ...]
> In ice-9/ftw.scm:
> 452: 15 [#<procedure 2375210 at ice-9/ftw.scm:451:38 (subdir result+visited)> # #]
> 450: 14 [loop "testsuite" "gcc-11.3.0/gcc" ...]
> In srfi/srfi-1.scm:
> 465: 13 [fold #<procedure ebad80 at ice-9/ftw.scm:451:38 (subdir result+visited)> ...]
> In ice-9/ftw.scm:
> 452: 12 [#<procedure ebad80 at ice-9/ftw.scm:451:38 (subdir result+visited)> # #]
> 450: 11 [loop "go.test" "gcc-11.3.0/gcc/testsuite" ...]
> In srfi/srfi-1.scm:
> 465: 10 [fold #<procedure 219a4b0 at ice-9/ftw.scm:451:38 (subdir result+visited)> ...]
> In ice-9/ftw.scm:
> 452: 9 [#<procedure 219a4b0 at ice-9/ftw.scm:451:38 (subdir result+visited)> # #]
> 450: 8 [loop "test" "gcc-11.3.0/gcc/testsuite/go.test" ...]
> In srfi/srfi-1.scm:
> 465: 7 [fold #<procedure 229ba80 at ice-9/ftw.scm:451:38 (subdir result+visited)> ...]
> In ice-9/ftw.scm:
> 452: 6 [#<procedure 229ba80 at ice-9/ftw.scm:451:38 (subdir result+visited)> # #]
> 450: 5 [loop "fixedbugs" "gcc-11.3.0/gcc/testsuite/go.test/test" ...]
> In srfi/srfi-1.scm:
> 465: 4 [fold #<procedure 20bab70 at ice-9/ftw.scm:451:38 (subdir result+visited)> ...]
> In ice-9/ftw.scm:
> 452: 3 [#<procedure 20bab70 at ice-9/ftw.scm:451:38 (subdir result+visited)> # #]
> 474: 2 [loop "issue27836.dir" ...]
> In guix/build/utils.scm:
> 540: 1 [#<procedure d188e0 at guix/build/utils.scm:536:28 (file stat errno result)> "gcc-11.3.0/gcc/testsuite/go.test/test/fixedbugs/issue27836.dir/Äfoo.go" ...]
> In unknown file:
> ?: 0 [scm-error misc-error #f "~A" ("find-files failed") #f]
>
> ERROR: In procedure scm-error:
> ERROR: find-files failed
>
> Deleting these files also don't work for the same reason, even when
> using the hex representation, i.e. (delete-file "\u00c4foo.go"), or with
> DELETE-FILE-RECURSIVELY.
>
> One workaround is to avoid the use of BOOTSTRAP-ORIGIN by applying the
> patches and snippet in phases, but that's suboptimal because it has to
> be done for all of GCC-BOOT0, LIBSTDC++, and GCC-FINAL.
To be clear, you’re calling ‘delete-file-recursively’ from a snippet,
right?
If so, maybe you could… avoid it somehow? :-)
Other options, as discussed on IRC, include adding ‘glibc-utf8-locales’
to the environment, or calling out to Coreutils as you proposed…
Ludo’.
prev parent reply other threads:[~2022-07-21 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 19:37 Dealing with non-ASCII file names in BOOTSTRAP-ORIGIN Marius Bakke
2022-07-18 21:00 ` Attila Lendvai
2022-07-19 18:43 ` Greg Hogan
2022-07-19 20:56 ` Marius Bakke
2022-07-21 15:02 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edyeldai.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=marius@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).