unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] web: Include blocked-by in graphql <issue>.
@ 2023-05-30  8:17 Christopher Baines
  2023-05-30  8:49 ` Christopher Baines
  0 siblings, 1 reply; 4+ messages in thread
From: Christopher Baines @ 2023-05-30  8:17 UTC (permalink / raw)
  To: guix-devel; +Cc: arunisaac, rekado

* mumi/web/graphql.scm (<issue>): Include blocked-by.
---
 mumi/web/graphql.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/mumi/web/graphql.scm b/mumi/web/graphql.scm
index aa4f38c..3cc19cd 100644
--- a/mumi/web/graphql.scm
+++ b/mumi/web/graphql.scm
@@ -63,7 +63,10 @@
               (list))))
   (messages (non-nullable-type (list-type <email>))
             (lambda (parent . _)
-              (issue-messages (bug-num parent)))))
+              (issue-messages (bug-num parent))))
+  (blocked-by (non-nullable-type (list-type <issue>))
+              (lambda (parent . _)
+                (map bug-status (bug-blockedby parent)))))
 
 (define-object-type <person>
   (name <string> (lambda (parent . _)
-- 
2.40.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] web: Include blocked-by in graphql <issue>.
  2023-05-30  8:17 [PATCH] web: Include blocked-by in graphql <issue> Christopher Baines
@ 2023-05-30  8:49 ` Christopher Baines
  2023-05-30 16:20   ` Arun Isaac
  0 siblings, 1 reply; 4+ messages in thread
From: Christopher Baines @ 2023-05-30  8:49 UTC (permalink / raw)
  To: guix-devel; +Cc: arunisaac, rekado

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]


Christopher Baines <mail@cbaines.net> writes:

> * mumi/web/graphql.scm (<issue>): Include blocked-by.
> ---
>  mumi/web/graphql.scm | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/mumi/web/graphql.scm b/mumi/web/graphql.scm
> index aa4f38c..3cc19cd 100644
> --- a/mumi/web/graphql.scm
> +++ b/mumi/web/graphql.scm
> @@ -63,7 +63,10 @@
>                (list))))
>    (messages (non-nullable-type (list-type <email>))
>              (lambda (parent . _)
> -              (issue-messages (bug-num parent)))))
> +              (issue-messages (bug-num parent))))
> +  (blocked-by (non-nullable-type (list-type <issue>))
> +              (lambda (parent . _)
> +                (map bug-status (bug-blockedby parent)))))
>  
>  (define-object-type <person>
>    (name <string> (lambda (parent . _)

I'm looking at this so that the qa-frontpage can see what issues are
blocked.

I'm not sure how to test this though.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] web: Include blocked-by in graphql <issue>.
  2023-05-30  8:49 ` Christopher Baines
@ 2023-05-30 16:20   ` Arun Isaac
  2023-05-30 17:39     ` Christopher Baines
  0 siblings, 1 reply; 4+ messages in thread
From: Arun Isaac @ 2023-05-30 16:20 UTC (permalink / raw)
  To: Christopher Baines, guix-devel; +Cc: rekado


Hi Chris,

Thanks for the patch! I have pushed it after renaming blocked-by to
blocked_by. Underscores are a bit cringey, but unfortunately GraphQL
doesn't like hyphens.

To see the effects of this change, we need to reconfigure berlin to run
the latest mumi. I will figure that out and do it soon.

Regards,
Arun


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] web: Include blocked-by in graphql <issue>.
  2023-05-30 16:20   ` Arun Isaac
@ 2023-05-30 17:39     ` Christopher Baines
  0 siblings, 0 replies; 4+ messages in thread
From: Christopher Baines @ 2023-05-30 17:39 UTC (permalink / raw)
  To: Arun Isaac; +Cc: guix-devel, rekado

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]


Arun Isaac <arunisaac@systemreboot.net> writes:

> Thanks for the patch! I have pushed it after renaming blocked-by to
> blocked_by. Underscores are a bit cringey, but unfortunately GraphQL
> doesn't like hyphens.
>
> To see the effects of this change, we need to reconfigure berlin to run
> the latest mumi. I will figure that out and do it soon.

Awesome, thanks for fixing my rough untested changes!

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-05-30 17:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-30  8:17 [PATCH] web: Include blocked-by in graphql <issue> Christopher Baines
2023-05-30  8:49 ` Christopher Baines
2023-05-30 16:20   ` Arun Isaac
2023-05-30 17:39     ` Christopher Baines

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).