From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id SDkVBUHV7GQRawEAauVa8A:P1 (envelope-from ) for ; Mon, 28 Aug 2023 19:11:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id SDkVBUHV7GQRawEAauVa8A (envelope-from ) for ; Mon, 28 Aug 2023 19:11:29 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D35123DACD for ; Mon, 28 Aug 2023 19:11:28 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=quQlzztV; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693242688; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=vKIsLGMofbROxowHWpehSnIURr5w6WNvBTjSNWKit8Y=; b=n8+pgslcmIF7EbxIDqUCx1ut87SQn1lvpAhwu0nVkSyM7GOZuxkv9vZiEKOCafQBjrDksS ImOb9L8zSLUxDmBM6Sbkm2dwvUr8sHl50W6FcuWtyY0BizLepxG+wzo+SzMojfczgfCeuX 2fZTK+Bi2iHDs3F102Ufonul0KBtXigLGRBQSNVKmHjNN2eOz5aPBKOh+pwxRKwqeimVMJ 0b6pRjyhjyuqwh9jkr0Bp7JMTKElLq8aT0wgCf127yDTuibxyTfg2u6X5984sbykdZdPGu wQJGtb1l7PZgueyL9DOR3xw1q9D6pN5pGFch3eW5YAYfiSAdSmmsA1Herdoztg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=quQlzztV; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693242688; a=rsa-sha256; cv=none; b=LkJ9QjIpAaOz/R1zVF7VY7zvbDCwHHmOCF78LMKqFv/UgABTSgzMW9GPrDpD7WC6lg9pG6 aICMNwxx3k94VKIZjWKcbv8A6W4V2jMBf2Ljyz6RN+qws3Sf+L04OiZ7KqBZg08cLBekd2 fleHsqGlCaXXtPerVCOp2zfekZfGxySPBRvh9h7QplwMJZML1YBHlcMdrHNQu91/mufbEL 8ZTh9ZY2b2rfKtOLU8I4mQ90lWuYqicAu4WVzTvynIe+Lmk9c3Cwd4nKTauITIZY10c3rp Y34PHahX8Y13qg21BSfQ1TsZPXyOkNrdv67udtSC+LCQDqJGBBCO9e7RiH3Jvg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qafl2-00051u-9S; Mon, 28 Aug 2023 13:10:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qafkt-0004zC-Tv for guix-devel@gnu.org; Mon, 28 Aug 2023 13:10:23 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qafkr-00051q-AU for guix-devel@gnu.org; Mon, 28 Aug 2023 13:10:23 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3fef29ce3e5so11066815e9.0 for ; Mon, 28 Aug 2023 10:10:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693242620; x=1693847420; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=vKIsLGMofbROxowHWpehSnIURr5w6WNvBTjSNWKit8Y=; b=quQlzztVpTj8/2+FyiYq1M57Th5Dw+gHy1v964MmjMObzo74tJ+YiHbBBdNjFJhOOD eo3IObU+cW7sUkGYQo/RuKb4ycHmrzIP2tMu2ETw59sPKCglsXh/jn+xA5bwt2gYqTMP L/jIditq+WyWwIWFV9Cfkw8J41240PiqaGf2+i8rgdom12ISUWmLde/GE1PGosDAVxPF a6LAK4nSO70jC3hOlSqp0q6YWMNU092f6gCfy38yj1nYWwsEW3+YMy8J86ACnrenDINB KnLsfoRKXeRxTfZLDAUbjo+QiVn/Ocin+aeTtg83s0BeVh6BLOLd3i6vc8h+N2TuhjOc SQIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693242620; x=1693847420; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vKIsLGMofbROxowHWpehSnIURr5w6WNvBTjSNWKit8Y=; b=G/O8HWtU2Qah0O1uNJH1/bfnyd6RTJdFcem7PIpvaw+bvCTDituslOJ3XcmPx/Yzqi PkXKEPuBgsdcR6e0INKPYQsRQNNDs+5WkKFOTYCd/j05/rp9vkDTeKl0jG7qgqSxwc2c GpPXdv5y9gjyrXdTnhcR2KPX99mkkoVUQJftZS1309VOrAI6gitq3BpHDXuyNeATujMH pkurCwsftIO+QuXVVRK35fxUWFVQTtRIhK0NGVD1/x/6tWf8EFE4yAA79omYBmmgr2qc /8NPv0Ijmj1/Dhk14qxwF8oNmFhMYeDsSNKI9a0ZNapVDcdIu/0xXwo5erjASTJ1fxa/ fruA== X-Gm-Message-State: AOJu0YxsLXCUBHRpvYVR8eQ/L4dZ+h0riILN0SaJhIkm7lKT+feRBMVK MQ6L7SWeNi5y0OT/cIHeIyCbLdqiPko= X-Google-Smtp-Source: AGHT+IHwiU6GMnFC3NWFM4Vr/SJPWXr09y7tVS5ba1EZ8wBanJjnMNlK3m9IG9jS8uqUlo8+84W/cg== X-Received: by 2002:a05:600c:5185:b0:3fe:dd78:8fbc with SMTP id fa5-20020a05600c518500b003fedd788fbcmr20526655wmb.3.1693242619707; Mon, 28 Aug 2023 10:10:19 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id c12-20020a05600c0acc00b003fee6f027c7sm14423987wmr.19.2023.08.28.10.10.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Aug 2023 10:10:19 -0700 (PDT) From: Simon Tournier To: kiasoc5@disroot.org, Attila Lendvai Cc: Wilko Meyer , Katherine Cox-Buday , guix-devel@gnu.org Subject: Re: How can we decrease the cognitive overhead for contributors? In-Reply-To: <0e88ad722f88591d5e79da9793a2a64e@disroot.org> References: <8735084vv2.fsf@wmeyer.eu> <0e88ad722f88591d5e79da9793a2a64e@disroot.org> Date: Mon, 28 Aug 2023 12:01:34 +0200 Message-ID: <87edjnqydd.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=zimon.toutoune@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_06_12=1.543, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -2.59 X-Spam-Score: -2.59 X-Migadu-Queue-Id: D35123DACD X-TUID: sP+eUk82rLNj Hi, On Sat, 26 Aug 2023 at 19:42, kiasoc5@disroot.org wrote: > I would like to hear from committers if non-committer reviews are=20 > helpful, because I don't really know how or what I can comment on for=20 > incoming patches on packages I'm not really familiar with. Well, I do not have enough committer experience. However, I commented several patches and my aim was the one I would like to see for helping me as committer before pushing. Because I am signing-off the commit, it is my responsibility to check that the commit is compliant with Guix standards. So, whatever I will read as other review, I will check myself. However, if another person has also checked, it helps me because it avoids me to double or triple-check in order to be sure I am not missing something. Somehow, another person looking at the patch reinforces my confidence that all is fine. Other said, without diluting the responsibility, it dilutes the pressure, somehow. Well, from my point of view, the comment =E2=80=9Cbuild locally=E2=80=9C is= not very helpful. The comment =E2=80=9Cwork locally=E2=80=9D is a bit more. IMHO, = the most helpful appears to me, in that order: 1. the check of license =E2=80=93 sometime upstream says the license is GPL when it=E2=80=99s true for most of the code but a tiny subpart uses some non-free license, such comment is very helpful. 2. the good writing of synopsis and description. 3. the =E2=80=99home-page=E2=80=99 field is correct. 4. some comments about the =E2=80=99arguments=E2=80=99 field. And the next level appears to me: 5. apply the comments about #2 or #3 or #4 and re-send another version (reroll-count). That=E2=80=99s what committers are often doing and exc= ept some cases, that is not a co-author ship. :-) Cheers, simon