From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 7C8wD8KWNmWvMgEAG6o9tA:P1 (envelope-from ) for ; Mon, 23 Oct 2023 17:52:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 7C8wD8KWNmWvMgEAG6o9tA (envelope-from ) for ; Mon, 23 Oct 2023 17:52:34 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D508A5E2EC for ; Mon, 23 Oct 2023 17:52:33 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DTtof++i; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698076354; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rXcNKxtGJWT7RPl51Y0BT34mVwdNh1UEWAm+/cY/eck=; b=u0OSxY69VeicZwfSD1votZx3YzLIxrG7LfrL6TFr528uGPr5qlfacM4oUreW37dQNuZnrW pTBJUnhn1ddmJhk0yj42sl/eziSWc0wIOBKGFGJADGH4st8I5edrO5tL0RzI1qq51wHIPr qpvl3T9+cW+8sIWXoDf3h71eV10oqwU/BSR4efXeb4ojb8XtM7mNEyiGhaDwfgBXxDqmHC XyYQ3SXfGxkGwIfd0sfxel1lC8nEtJCNmm3jLCElMqJK7wW3X7hbKmznBsEpPwUy5AcZcH GzLKxwz03fhysH+7jlW4quE3HsMkLsypYVEG21SompQrBNKqckqq0Q18OG2gEg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DTtof++i; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698076354; a=rsa-sha256; cv=none; b=PdD6hc9TjtW0lb0k8hRW8P25liDreWsfSTrxBDLr9kZc84mRJsvbW2C6cUYUNFdsE3ggUr QSyPi4nvGIy18Bm9IiJMmSAF1gqD6lcM4nCWKoIDPFG1sbymysjRNSNeM5TgaC5H61NXNa Tf4rMiE9ufGQXZY3/8cDi/NEL8zbnSgR3xtNpN5CRJdn0tMa1q81Ao8goEMiPzhKT4US2Q l6zA9M/PQhyEiHzySdVupWCTduY+pv78C4eu5JZbMlYwzTq48KF7Eyv8Rm7dKVEvTjV0XZ mtyHcK0vFNBHn9x4Pb+OmMYKTdBYjj3EbJW03TwxDK7c37HKo31ka36mdoE5kw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1quxDj-0005K5-FB; Mon, 23 Oct 2023 11:51:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quxDe-0005ID-Cw for guix-devel@gnu.org; Mon, 23 Oct 2023 11:51:56 -0400 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1quxDV-0006Da-Lq; Mon, 23 Oct 2023 11:51:52 -0400 Received: by mail-qt1-x82c.google.com with SMTP id d75a77b69052e-41cd58eb037so23895021cf.1; Mon, 23 Oct 2023 08:51:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698076303; x=1698681103; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=rXcNKxtGJWT7RPl51Y0BT34mVwdNh1UEWAm+/cY/eck=; b=DTtof++i6oU38XtUyeMrued0LEsteL+pcbCWUvo2GyVyUavTewxP3YHsWWpFavuJUl s+sXB5sxXgZZ3jdORoo8Z/SoWSOtQ+c73hgLEXSgJGXYrh5BJZivoI0sF+KyIYv7AlCL 8HZYTaOvBmwQLy1scTICraX4e7Mhj4WPz1QQG/9BgvWO1q5uhHmQQRwuISgbqMCI7gLV 3nvA0NIj0pL7SAXcVMxlnY9VD8tQiNlHqMkZZSbTUmYOqino7l+LBX1po4ZuoKI3H1DA qQtHBgdqIx0ZnbsSdfLoC1rx4ymxM1FlmGjTNqik2yRdxIRMSimpH6Ulr40wM7jnwmrq gkSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698076303; x=1698681103; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rXcNKxtGJWT7RPl51Y0BT34mVwdNh1UEWAm+/cY/eck=; b=R/jeM6iB02de6deB0jyo57rntfEkHP/DFwTxgqjCXAk4bYyhPedOZPDCp7gVBGbTFc OnoWnKMR8isbOiAK08FQz/i93DZfoIj1Lk+dBJapr6XYUAku6aTceeRo31X4fg4BPAIz AgbxoRwZnP+oFUj2++PxCQ3G2gx7kOMXePVCzTjQj0dEP8VyXfrnZqcfqBV1Rn/OiRyI njz/7FWaaEvBMktDBWVMHtnJoyZfwOSBSTmdulqMKe6HsNaVoMUqG/XtojWRbKP0UxCE BZYKjB7fOuIwpUImbjjpTQpM1sDgrbCVU8goGlOnOZrbrv0i8MKitmY0IBGaYLx8rOFY hBkg== X-Gm-Message-State: AOJu0Ywix37jf03uVI0thbOt50C3Sld8gg4xBViq1XAQYKoW+EHa8iqm +wmVeFG3+oX19bAqIeiK562P8vTzn/jYZw== X-Google-Smtp-Source: AGHT+IHFAu3BIPkQtxXoxJ7YWgQgcOD1Sz/QurS5D+6oE83uhheFLF14tgSXVjFbwUw0uumqOuwnOw== X-Received: by 2002:a05:622a:116:b0:419:4e1c:68f9 with SMTP id u22-20020a05622a011600b004194e1c68f9mr12774260qtw.47.1698076302673; Mon, 23 Oct 2023 08:51:42 -0700 (PDT) Received: from hurd (dsl-10-148-194.b2b2c.ca. [72.10.148.194]) by smtp.gmail.com with ESMTPSA id r8-20020ac85e88000000b00419801b1094sm2820402qtx.13.2023.10.23.08.51.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 08:51:42 -0700 (PDT) From: Maxim Cournoyer To: guix-devel@gnu.org Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [RFC]: Skipping rust crate tests by default In-Reply-To: (Efraim Flashner's message of "Mon, 23 Oct 2023 13:04:31 +0300") References: <87sf67sr8e.fsf@gmail.com> Date: Mon, 23 Oct 2023 11:51:41 -0400 Message-ID: <87edhl72wi.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::82c; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x82c.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -9.40 X-Spam-Score: -9.40 X-Migadu-Queue-Id: D508A5E2EC X-Migadu-Scanner: mx2.migadu.com X-TUID: K54/L7Ex3ZG5 Hi Efraim! Efraim Flashner writes: [...] >> > error: unnecessary parentheses around index expression >> > --> /tmp/guix-build-rust-nalgebra-0.21.1.drv-0/nalgebra-0.21.1/src/linalg/convolution.rs:49:53 >> > | >> > 49 | conv[i] += self[u] * kernel[(i - u)]; >> > | ^ ^ >> > | >> > help: remove these parentheses >> > | >> > 49 - conv[i] += self[u] * kernel[(i - u)]; >> > 49 + conv[i] += self[u] * kernel[i - u]; >> > | >> > >> > error: aborting due to 2 previous errors >> > >> > error: doctest failed, to rerun pass `--doc` >> > >> > >> > crates.io lists this version as being released more than 3 years ago and >> > targeting the 2018 edition of rust. When built with our current >> > rust-1.68.2 the doc test passes but not with 1.70.0. The current >> > upstream version of nalgebra is 0.32.3, so it's unlikely that they'd >> > release a new version with the doc tests fixed, but I haven't contacted >> > them about it. >> >> OK. Asking in ##rust on libera chat (unofficial channel), I got as suggestion >> to call 'carge test' with the '--cap-lints=allow' option documented >> here [0], which should effectively disable just the lint checks, which >> is better than disabling the full test suite. >> >> [0] https://doc.rust-lang.org/rustc/lints/levels.html > > I checked the cargo-build-system and we do actually use > --cap-lints=allow for building and for testing. Ah! It must be something recent, as it was not the case (and still isn't) when I checked on the master branch. Or else I fail to see where/how it's specified. And nalgebra still fails lint tests with the above --caps-lints=allow option? If that's so that'd suggest that packages can enforce their own settings and that this overrides cargo flags given at the command line... which sounds like a cargo bug. -- Thanks, Maxim