From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id sNY2OBBjLmeNOwEAe85BDQ:P1 (envelope-from ) for ; Fri, 08 Nov 2024 19:14:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id sNY2OBBjLmeNOwEAe85BDQ (envelope-from ) for ; Fri, 08 Nov 2024 20:14:25 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; none Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D1CEE5B5A7 for ; Fri, 08 Nov 2024 20:14:24 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t9UQd-0004de-5E; Fri, 08 Nov 2024 14:13:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9UQU-0004d0-3K for guix-devel@gnu.org; Fri, 08 Nov 2024 14:13:46 -0500 Received: from fhigh-b8-smtp.messagingengine.com ([202.12.124.159]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9UQR-0002bf-2l for guix-devel@gnu.org; Fri, 08 Nov 2024 14:13:45 -0500 Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfhigh.stl.internal (Postfix) with ESMTP id F09D2254008E; Fri, 8 Nov 2024 14:13:36 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Fri, 08 Nov 2024 14:13:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1731093216; x=1731179616; bh=vW+MFM0Wj7BOQtpF/ZNZuxWi75r9rBuKnYWUjFpOm2g=; b= ZL0JICKxZ8oMxmoGpNwh/TY0UMIsNdaenEv4EsARptAnFGSplAyPVp/+DiCcHRpr V6/7Pd10ggN+SzoGFwLV1dGh0AcvJ+1VsKOgQHZjCP//aOQpNEmFunZoKuREfyJg /LNYX2eM6UQfZtGODOnPpfVCcXkGkmdZ9958gSXB6NqMhNgjSwRWsBCPEe5+K9mo EA/ULRFMuMyKsBEPoy6piOqYQfpBJ/uZ4cUV4RVtuYUUIXcjdwig7K/Dby8lEDIn AqCsHMx17UlL2+AfnXbxPKF0jM2hVIM4erP+KseKUOoNoKVw+HptH8roROULyp0n UbydsCbO4n5vEfcq0BrKCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731093216; x= 1731179616; bh=vW+MFM0Wj7BOQtpF/ZNZuxWi75r9rBuKnYWUjFpOm2g=; b=i 7i6nMNtqYzpxzDOMQ9QcmKDVFz0Ee8xvlSI+kpybFnrwHRItfaVcA8dVblPZYi9/ 9AIcu9CZW84+8vpi7PFswizEQn3wzqfP3XJNXmgQ0UOmwr5uJtpM65U6v//qEnm2 IO6HNDVxAxVF0RM1G5d291ReCHzoRa57DBg4l28MeLzU6p3Fc8f4A+ic/DCJ2EPs /yU9feRziNsmGND7xv9QTckqAItf9BQ6DWLrEBoNKT+p4voHqjFDngWwJ3O2gy4M fwBIcDlJd5PhVuykyjauW3H0imkJB8YhYd46TFURjFtZfGwLoogsL1yxVUopP/Ni hK4t9ZelqE5Zbuhc6YnEA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrtdeigdduudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfhgfhffvvefuffgjkfggtgfgsehtqhertddtreej necuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdhtvheqne cuggftrfgrthhtvghrnhephfelvedtieeffffggeeivdeukedutedtveejfffhleeileef heeggfdugfeiuefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepihgrnhesrhgvthhrohhsphgvtgdrthhvpdhnsggprhgtphhtthhopedvpdhm ohguvgepshhmthhpohhuthdprhgtphhtthhopehguhhigidquggvvhgvlhesghhnuhdroh hrghdprhgtphhtthhopehjuhhlihesihhntggrnhgrrdhorhhg X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Nov 2024 14:13:36 -0500 (EST) References: <0W9NMS.7ID0I9IORJ19@incana.org> User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure To: Juliana Sims Cc: guix-devel@gnu.org Subject: Re: Magic Wormhole Package Weirdness/Potential Security Issues? Date: Fri, 08 Nov 2024 11:09:10 -0800 In-reply-to: <0W9NMS.7ID0I9IORJ19@incana.org> Message-ID: <87ed3l35el.fsf@meson> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=202.12.124.159; envelope-from=ian@retrospec.tv; helo=fhigh-b8-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.00 X-Spam-Score: -4.00 X-Migadu-Queue-Id: D1CEE5B5A7 X-Migadu-Scanner: mx13.migadu.com X-TUID: TXZ+9eMsFIJN Hi Juliana, I=E2=80=99ve observed some similar weirdness in the past when I=E2=80=99ve = updated=20 versions. I believe what=E2=80=99s happening is that Guix uses the hash=20 to look up the file in a content-addressed store (either the local=20 store or SWH), and is lacking verification that the retrieved=20 object is the expected one. =E2=80=94 Ian Juliana Sims writes: > Hey folks, > > I tried to update magic-wormhole today and things went super=20 > smoothly. > All I had to do was change the version number. > > I didn't even have to change the source hash. > > If that strikes you as odd, good! It should! > > To cover all my bases, I pk'd the hash produced by `pypi-uri`=20 > and used > `guix download` to try to fetch the same file and check its=20 > hash, only > to find that `guix download` couldn't find anything at that URL=20 > or its > fallbacks. > > To test if things were being exceptionally weird, I switched to > pulling and building from git, and the build failed, expectedly, > probably because one of the dependencies > (magic-wormhole-transit-relay) was not the right version, which=20 > was > what I had initially expected to happen. > > Does anyone know what might be going on here? Given the=20 > intended > secure nature of this program, I'm concerned there may be=20 > something > malicious happening somewhere along the way. I would love an > explanation that quiets that concern. > > You can look at the current magic-wormhole package source and=20 > play > around with it yourself to see what I'm talking about. > > Best, > Juli > > PS I was trying to update all three packages in=20 > magic-wormhole.scm, > but the transit relay in particular requires later versions of=20 > twisted > and autobahn than the other two, which is minorly annoying. I=20 > know > twisted can't be updated without rebuilding a bunch of stuff, so=20 > I > don't plan to pursue this further for the time being.