From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: luajit recipe Date: Wed, 05 Feb 2014 00:17:14 +0100 Message-ID: <87d2j2a2o5.fsf@gnu.org> References: <87iosulff2.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WApJw-0000HO-6m for guix-devel@gnu.org; Tue, 04 Feb 2014 18:22:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WApJo-0005sz-TP for guix-devel@gnu.org; Tue, 04 Feb 2014 18:22:24 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:57047) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WApJo-0005sp-No for guix-devel@gnu.org; Tue, 04 Feb 2014 18:22:16 -0500 In-Reply-To: <87iosulff2.fsf@gmail.com> (Raimon Grau's message of "Tue, 04 Feb 2014 22:46:25 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Raimon Grau Cc: guix-devel@gnu.org Hello! Raimon Grau skribis: > I've been following this project for some time, and finally got through > using it for a few packages, and made my first recipe. Great, welcome aboard! :-) Overall this looks good to me, > (arguments > '(#:modules ((guix build gnu-build-system) > (guix build utils) > (srfi srfi-1)) Actually srfi-1 is not needed because =E2=80=98alist-delete=E2=80=99 is re-= exported by (guix build utils), which is used by default. So the #:modules argument can be dropped altogether. > #:phases > (alist-replace > 'install > (lambda* (#:key system outputs #:allow-other-keys) > (let ((out (assoc-ref outputs "out"))) > (zero? (system* "make" "install" > (string-append " PREFIX=3D" out))))) > (alist-replace > 'build > (lambda* (#:key system outputs #:allow-other-keys) > (let ((out (assoc-ref outputs "out"))) > (zero? (system* "make" (string-append " PREFIX=3D"= out))))) > (alist-delete > 'check > (alist-delete 'configure > %standard-phases)))))) This works well, but it can be simplified as: #:tests? #f #:make-flags (list (string-append "PREFIX=3D" (assoc-ref %outputs "out"))) > (description > "LuaJIT is a Just-In-Time Compiler (JIT) for the Lua > programming language. Lua is a powerful, dynamic and light-weight program= ming > language. It may be embedded or used as a general-purpose, stand-alone > language. > > LuaJIT is Copyright =C2=A9 2005-2014 Mike Pall") The description doesn=E2=80=99t contain a copyright statement in general. Could you send an updated version with these changes in the format produced by =E2=80=98git format-patch=E2=80=99, and using a ChangeLog-style= commit log (see =E2=80=98HACKING=E2=80=99 for details)? That makes it easier to apply= the patch. Let us know if you have any questions. Thanks! Ludo=E2=80=99.