From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: Add gsegrafix and depdendent libraries. Date: Sun, 25 May 2014 15:54:12 +0200 Message-ID: <87d2f20xrv.fsf@gnu.org> References: <1401007682-24126-1-git-send-email-jmd@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WoYsW-0002Ly-Nk for guix-devel@gnu.org; Sun, 25 May 2014 09:54:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WoYsS-0008Og-0R for guix-devel@gnu.org; Sun, 25 May 2014 09:54:20 -0400 In-Reply-To: <1401007682-24126-1-git-send-email-jmd@gnu.org> (John Darrington's message of "Sun, 25 May 2014 10:48:01 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: John Darrington Cc: guix-devel@gnu.org Woow, nice! Overall looks good to me, modulo the mostly cosmetic comments below. John Darrington skribis: > * gnu/packages/math.scm (gsegrafix): New variable. > * gnu/packages/gnome.scm (libIDL, ORBit2, libbonobo, GConf, gnome-mime-da= ta, > gnome-vfs, libgnome, libart_lgpl, libgnomecanvas, libgnomeui, > libglade, libgnomeprint, libgnomeprintui, pangox-compat, libbonoboui): = New variables. > * gnu/packages/gtk.scm (pangox-compat): New variable. Please, 80 chars max per line. > +(define-public libIDL Lower-case. > + (package > + (name "libIDL") Ditto. > + (synopsis "create trees of CORBA Interface Definition Language files= ") =E2=80=9CCreate=E2=80=9D. > + (description "libIDL is a library for creating trees of CORBA Inter= face Definition Language (IDL) files, which is a specification for defining= portable interfaces. libIDL was initially written for ORBit (the ORB from = the GNOME project, and the primary means of libIDL distribution). However, = the functionality was designed to be as reusable and portable as possible.") 80 chars. > +(define-public ORBit2 > + (package > + (name "ORBit2") Lower-case both. > + (arguments > + ;; The programmer kindly gives us a hook to turn off deprecation war= nings ... > + `(#:configure-flags '("DISABLE_DEPRECATED_CFLAGS=3D-DGLIB_DISABLE_DE= PRECATION_WARNINGS") Would passing CPPFLAGS=3D-DGLIB_DISABLE_DEPRECATION_WARNINGS as #:configure-flags work? If yes, that=E2=80=99s preferable to modifying Makefile.in. > + (description "ORBit2 is a CORBA 2.4-compliant Object Request Broker= (ORB) featuring mature C, C++ and Python bindings.") 80 chars. > +;; Licence notice is unclear. The Web page simply say "GPL" without giv= ing a version. > +;; SOME of the code files have licence notices for GPLv2+ > +;; The tarball contains files of the text of GPLv2 and LGPLv2 > + (license license:gpl2+)))=20 Please align the comment (indent-for-tab-command in Emacs should get it right.) > + (arguments > + ;; The programmer kindly gives us a hook to turn off deprecation war= nings ... > + `(#:configure-flags '("DISABLE_DEPRECATED_CFLAGS=3D-DGLIB_DISABLE_DE= PRECATION_WARNINGS") CPPFLAGS? > + (synopsis "framework for creating reusable components for use in GNO= ME applications") =E2=80=9CFramework=E2=80=9D. > + (description "Bonobo is a framework for creating reusable components= for use in GNOME applications, built on top of CORBA.") 80 chars. > +;; Licence not explicitly stated. Source files contain no licence notic= es. > +;; Tarball contains text of both GPLv2 and LGPLv2 > +;; GPLv2 covers both conditions Indent. > +(define-public GConf > + (package > + (name "GConf") Case. > + (synopsis "store application preferences") =E2=80=9CStore=E2=80=9D. > + (name "gnome-vfs") > + (version "2.24.4") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "mirror://gnome/sources/" name "/" (string-take versi= on 4) "/" name "-" > + version > + ".tar.bz2")) > + (sha256 > + (base32 "1ajg8jb8k3snxc7rrgczlh8daxkjidmcv3zr9w809sq4p2sn9= pk2")))) > + (build-system gnu-build-system) > + (arguments > + ;; The programmer kindly gives us a hook to turn off deprecation war= nings ... > + `(#:configure-flags '("DISABLE_DEPRECATED_CFLAGS=3D-DGLIB_DISABLE_DE= PRECATION_WARNINGS") CPPFLAGS? > + (synopsis "access files and folders in GNOME applications") =E2=80=9CAccess=E2=80=9D > + (name "libgnome") > + (version "2.32.1") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "mirror://gnome/sources/" name "/" (string-take versi= on 3) "/" name "-" > + version > + ".tar.bz2")) > + (sha256 > + (base32 > + "197pnq8y0knqjhm2fg4j6hbqqm3qfzfnd0irhwxpk1b4hqb3kimj")))) > + (build-system gnu-build-system) > + (arguments > + `(#:phases > + (alist-cons-before > + 'configure 'enable-deprecated > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "libgnome/Makefile.in" > + (("-DG_DISABLE_DEPRECATED") "-DGLIB_DISABLE_DEPRECATION_WARN= INGS"))) CPPFLAGS? > + (synopsis "useful routines for building applications") =E2=80=9CUseful=E2=80=9D > +(define-public libart_lgpl > + (package > + (name "libart_lgpl") Hyphen instead of underscore. > + (name "libgnomecanvas") > + (version "2.30.3") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "mirror://gnome/sources/" name "/" (string-take versi= on 4) "/" name "-" > + version > + ".tar.gz")) > + (sha256 > + (base32 > + "1nhnq4lfkk8ljkdafscwaggx0h95mq0rxnd7zgqyq0xb6kkqbjm8")))) > + (build-system gnu-build-system) > + (propagated-inputs `(("libart_lgpl" ,libart_lgpl) > + ("gtk+" ,gtk+-2))) Please add a comment saying why they=E2=80=99re propagated. > + (synopsis "flexible widget for creating interactive structured graph= ics") =E2=80=9CFlexible=E2=80=9D. > + (name "libgnomeui") > + (version "2.24.5") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "mirror://gnome/sources/" name "/" (string-take versi= on 4) "/" name "-" > + version > + ".tar.bz2")) > + (sha256 > + (base32 > + "03rwbli76crkjl6gp422wrc9lqpl174k56cp9i96b7l8jlj2yddf")))) > + (build-system gnu-build-system) > + (propagated-inputs `(("libgnome" ,libgnome) > + ("libgnome-keyring" ,libgnome-keyring))) Comment on why they=E2=80=99re propagated. > + (synopsis "additional widgets for applications") =E2=80=9CAdditional=E2=80=9D > + (synopsis "load glade interfaces and access the glade built widgets") =E2=80=9CLoad Glade user interfaces=E2=80=9D maybe? > + (synopsis "high-quality printing framework for GNOME") Maybe just =E2=80=9CPrinting framework for GNOME=E2=80=9D. > + (synopsis "high-quality printing framework for GNOME") > + (description "Gnome-print is a high-quality printing framework for = GNOME.") Copy-paste here, should be =E2=80=9CUser interface for GNOME=E2=80=99s prin= ting framework=E2=80=9D? > + (native-inputs > + `(("intltool" ,intltool) > + ("xorg-server" ,xorg-server) ;; For running the tests Use one semicolon for margin comments. > + (synopsis "some user interface controls using Bonobo") =E2=80=9CSome=E2=80=9D > + (synopsis "functions now obsolete in pango") =E2=80=9CFunctions=E2=80=9D >=20=20 > + > (define-public superlu-dist Extraneous newline. Thank you! Ludo=E2=80=99.