From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add ninja.
Date: Mon, 12 Jan 2015 10:53:19 +0100
Message-ID: <87d26kuxyo.fsf@gnu.org>
References: <1420810817-23613-1-git-send-email-iyzsong@gmail.com>
	<87fvbk3tvy.fsf@gnu.org> <87387i99n2.fsf@gmail.com>
	<877fwukasx.fsf@gnu.org> <87oaq66mmw.fsf@gmail.com>
	<87sifhd1wq.fsf@gnu.org> <87d26lk149.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48675)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YAbgd-00080H-20
	for guix-devel@gnu.org; Mon, 12 Jan 2015 04:53:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YAbgX-00028h-Su
	for guix-devel@gnu.org; Mon, 12 Jan 2015 04:53:26 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:36521)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YAbgX-00025I-Kf
	for guix-devel@gnu.org; Mon, 12 Jan 2015 04:53:21 -0500
In-Reply-To: <87d26lk149.fsf@gmail.com> (=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Sun, 11 Jan 2015 19:28:22 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: guix-devel@gnu.org

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:
>>
>>> From 712f161a358a4bbcf005c5875e6d91eff21bdef4 Mon Sep 17 00:00:00 2001
>>> From: =3D?UTF-8?q?=3DE5=3DAE=3D8B=3DE6=3D96=3D87=3DE6=3DAD=3DA6?=3D <iy=
zsong@gmail.com>
>>> Date: Fri, 9 Jan 2015 21:37:30 +0800
>>> Subject: [PATCH] gnu: Add ninja.
>>>
>>> * gnu/packages/ninja.scm: New file.
>>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>>
>> Yes, OK to push, thanks!
> Even with 'system', the test InterruptChild failed on hydra for x86_64,
> but it passed for i686, mips64el and my x86_64 locally by 'guix build'.

I don=E2=80=99t see any failures actually:

  http://hydra.gnu.org/job/gnu/master/ninja-1.5.3.i686-linux
  http://hydra.gnu.org/job/gnu/master/ninja-1.5.3.mips64el-linux
  http://hydra.gnu.org/job/gnu/master/ninja-1.5.3.x86_64-linux

Are you sure it failed?

> Perhaps it's a random issue?

It looks like it.  It builds fine on my machine (x86_64).

I=E2=80=99ve looked at the test in question and it=E2=80=99s not obvious wh=
at could go
wrong:

--8<---------------cut here---------------start------------->8---
TEST_F(SubprocessTest, InterruptChild) {
  Subprocess* subproc =3D subprocs_.Add("kill -INT $$");
  ASSERT_NE((Subprocess *) 0, subproc);

  while (!subproc->Done()) {
    subprocs_.DoWork();
  }

  EXPECT_EQ(ExitInterrupted, subproc->Finish());
}
--8<---------------cut here---------------end--------------->8---

I think the idea is that =E2=80=98subproc_.Add=E2=80=99 launches a shell th=
at gets
interrupted by the =E2=80=98kill=E2=80=99 subprocess, which =E2=80=98Finish=
=E2=80=99 must reflect.

Thanks,
Ludo=E2=80=99.