From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: RFC: Build system hacks for Guix do not belong in 'source' Date: Thu, 05 Mar 2015 23:05:47 +0100 Message-ID: <87d24ndrr8.fsf@gnu.org> References: <1424552053-17323-1-git-send-email-rekado@elephly.net> <1424552053-17323-2-git-send-email-rekado@elephly.net> <878ufr6kf0.fsf@mango.localdomain> <87h9udbraa.fsf@mango.localdomain> <871tlexf9r.fsf@gnu.org> <87twy9abtb.fsf@mango.localdomain> <87lhjk61nb.fsf@gnu.org> <87h9u4akv7.fsf@mango.localdomain> <87h9u40vus.fsf@netris.org> <87zj7t8cj8.fsf@mango.localdomain> <87y4nd8cao.fsf@mango.localdomain> <87wq2x81dr.fsf@mango.localdomain> <87oao7guh3.fsf_-_@netris.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTdu1-0004zE-4U for guix-devel@gnu.org; Thu, 05 Mar 2015 17:05:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTdtx-0007ED-VP for guix-devel@gnu.org; Thu, 05 Mar 2015 17:05:57 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTdtx-0007Dt-Rb for guix-devel@gnu.org; Thu, 05 Mar 2015 17:05:53 -0500 In-Reply-To: <87oao7guh3.fsf_-_@netris.org> (Mark H. Weaver's message of "Thu, 05 Mar 2015 13:38:48 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mark H Weaver Cc: guix-devel@gnu.org Mark H Weaver skribis: > I don't think we should be making these kinds of changes in 'snippets'. > > When I ask for the source code via "guix build -S ", I expect > freedom fixes and other bug fixes, and maybe even enhancements needed > for Guix that would also work fine on other systems (e.g. adding an > environment variable). > > However, the package 'source' should not include build system hacks that > are specific to Guix and would interfere with the package functionality > on other platforms, IMO. > > I think that both the 'ldconfig -> true' hack and the LIBDIR > substitution should be moved to a build phase for both of these > packages. > > Other opinions? I think one of the goals of =E2=80=98guix build -S=E2=80=99 is that you can= take the source and build it *on GuixSD* with hopefully few additional modifications. >From that perspective, the =E2=80=9Chacks=E2=80=9D are really fixes or work= arounds (/sbin/ldconfig doesn=E2=80=99t exist on GuixSD.) Now, granted, there are inelegant workarounds that we=E2=80=99d rather hide; these two may well fall into this category, so I=E2=80=99m fine with moving= them to a build phase. Ricardo? Still, it=E2=80=99s not obvious to me where to draw the line in the general case. Ludo=E2=80=99.