[PATCH] gnu: mpd: Add additional optional inputs.

[PATCH] gnu: mpd: Add additional optional inputs.

[David Thompson]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-mpd-Add-additional-optional-inputs.patch --]
[-- Type: text/x-diff, Size: 2291 bytes --]

From 177a758f24d3f19a763e69d42d0ada4db8079090 Mon Sep 17 00:00:00 2001
From: David Thompson <dthompson2@worcester.edu>
Date: Sun, 26 Apr 2015 20:37:35 -0400
Subject: [PATCH] gnu: mpd: Add additional optional inputs.

* gnu/packages/mpd.scm (mpd): Add mpg123, libshout, fluidsynth, openal,
  libmpcdec, wavpack, libcdio-paranoia, expat, and samba inputs.
---
 gnu/packages/mpd.scm | 25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index f89d3ed..9260de9 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -43,7 +43,12 @@
   #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages databases)
   #:use-module (gnu packages video)
-  #:use-module (gnu packages xiph))
+  #:use-module (gnu packages xiph)
+  #:use-module (gnu packages audio)
+  #:use-module (gnu packages cdrom)
+  #:use-module (gnu packages xml)
+  #:use-module (gnu packages samba)
+  #:use-module (gnu packages avahi))
 
 (define-public libmpdclient
   (package
@@ -99,28 +104,30 @@ interfacing MPD in the C, C++ & Objective C languages.")
               ("opus" ,opus)
               ("pulseaudio" ,pulseaudio)
               ("sqlite" ,sqlite)
-              ("zlib" ,zlib)))
+              ("zlib" ,zlib)
+              ("mpg123" ,mpg123)
+              ("libshout" ,libshout)
+              ("fluidsynth" ,fluidsynth)
+              ("openal" ,openal)
+              ("libmpcdec" ,libmpcdec)
+              ("wavpack" ,wavpack)
+              ("libcdio-paranoia" ,libcdio-paranoia)
+              ("expat" ,expat)
+              ("samba" ,samba)))
     (native-inputs `(("pkg-config" ,pkg-config)))
     ;; Missing optional inputs:
     ;;   libyajl
-    ;;   libcdio_paranoia
     ;;   libmms
     ;;   libadplug
     ;;   libaudiofile
     ;;   faad2
-    ;;   fluidsynth
     ;;   libgme
-    ;;   libshout
-    ;;   libmpg123
     ;;   libmodplug
-    ;;   libmpcdec
     ;;   libsidplay2
-    ;;   libwavpack
     ;;   libwildmidi
     ;;   libtwolame
     ;;   libroar
     ;;   libjack
-    ;;   OpenAL
     (synopsis "Music Player Daemon")
     (description "Music Player Daemon (MPD) is a flexible, powerful,
 server-side application for playing music.  Through plugins and libraries it
-- 
2.1.4


[-- Attachment #2: Type: text/plain, Size: 136 bytes --]


-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

Re: [PATCH] gnu: mpd: Add additional optional inputs.

[Ricardo Wurmus]

I'm unclear on how to treat optional inputs (in general and in this
particular case).  Should we offer "mpd-minimal" with minimal inputs and
"mpd" with everything, or a "custom-mpd" function to create a package
with a certain feature subset?

In general I think it is good to also have a minimal package for
customisation in addition to a default package offering a richer feature
set.

What do you think?

Re: [PATCH] gnu: mpd: Add additional optional inputs.

[Andreas Enge]

Usually, I try to add all possible inputs, to have a package that works
out of the box in all situations. There may be extreme cases like texlive,
where the "full" package is just so big that one also wants a smaller one.

Andreas

Re: [PATCH] gnu: mpd: Add additional optional inputs.

[Andreas Enge]

On Sun, Apr 26, 2015 at 08:38:50PM -0400, David Thompson wrote:
>                ("pulseaudio" ,pulseaudio)
>                ("sqlite" ,sqlite)
> -              ("zlib" ,zlib)))
> +              ("zlib" ,zlib)
> +              ("mpg123" ,mpg123)
> +              ("libshout" ,libshout)
> +              ("fluidsynth" ,fluidsynth)
> +              ("openal" ,openal)

Could you order the inputs alphabetically? This  makes it much easier to find
a particular input (I have seen packages with the same input twice, once at
the beginning, once at the end...).

Andreas

Re: [PATCH] gnu: mpd: Add additional optional inputs.

[Ludovic Courtès]

Ricardo Wurmus <rekado@elephly.net> skribis:

> I'm unclear on how to treat optional inputs (in general and in this
> particular case).  Should we offer "mpd-minimal" with minimal inputs and
> "mpd" with everything, or a "custom-mpd" function to create a package
> with a certain feature subset?

That’s one possibility.  In the case of mpd, it probably makes sense.

Another one, if these inputs are used for plugins or additional
programs, is to move those in separate outputs (similar to the ‘gui’
output of ‘git’, etc.)

Ludo’.