unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: pdf: Fix installing desktop files of zathura packages.
Date: Tue, 07 Jul 2015 15:59:36 -0400	[thread overview]
Message-ID: <87d20320yf.fsf@netris.org> (raw)
In-Reply-To: <87d203ixcj.fsf@gmail.com> (Alex Kost's message of "Tue, 07 Jul 2015 22:25:32 +0300")

Alex Kost <alezost@gmail.com> writes:

> Mark H Weaver (2015-07-07 21:36 +0300) wrote:
>
>> diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
>> index 82e8c88..6cdc846 100644
>> --- a/gnu/packages/pdf.scm
>> +++ b/gnu/packages/pdf.scm
>> @@ -172,8 +172,9 @@
>>      (build-system gnu-build-system)
>>      (arguments
>>       `(#:make-flags
>> -       `(,(string-append "DESTDIR=" (assoc-ref %outputs "out"))
>> -          "PLUGINDIR=/lib/zathura" "CC=gcc")
>> +       `(,(string-append "PREFIX=" %output)
>> +         ,(string-append "PLUGINDIR=" %output "/lib/zathura")
>> +         "CC=gcc")
>
> As you change the whole clause anyway, wouldn't it be more good-looking
> to remove those "`" / "," and just use "list" instead?:
>
>           (list (string-append "PREFIX=" %output)
>                 (string-append "PLUGINDIR=" %output "/lib/zathura")
>                 "CC=gcc")

Agreed.  Pushed with this change.

    Thanks!
      Mark

      reply	other threads:[~2015-07-07 19:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-07  8:33 [PATCH] gnu: pdf: Fix installing desktop files of zathura packages Alex Kost
2015-07-07  8:43 ` Paul van der Walt
2015-07-07 17:40   ` Alex Kost
2015-07-07 15:07 ` Mark H Weaver
2015-07-07 17:39   ` Alex Kost
2015-07-07 18:36     ` Mark H Weaver
2015-07-07 19:25       ` Alex Kost
2015-07-07 19:59         ` Mark H Weaver [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d20320yf.fsf@netris.org \
    --to=mhw@netris.org \
    --cc=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).