From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH] Add MAFFT.
Date: Wed, 16 Sep 2015 23:09:56 +0200
Message-ID: <87d1xi6pgb.fsf@elephly.net>
References: <55B0E173.1030406@uq.edu.au> <876158xcoo.fsf@mdc-berlin.de>
	<55B44F96.8050808@uq.edu.au> <20150726094338.GA24898@debian>
	<20150726102915.GA32496@debian> <55BBF9E6.50403@uq.edu.au>
	<87d1ybhypp.fsf@gnu.org> <20150907085519.GA4513@debian>
	<55F4187B.8020804@uq.edu.au> <87eghyazi9.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45321)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZcJy1-0007uD-Nl
	for guix-devel@gnu.org; Wed, 16 Sep 2015 17:10:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZcJy0-0006kS-Id
	for guix-devel@gnu.org; Wed, 16 Sep 2015 17:10:13 -0400
In-reply-to: <87eghyazi9.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>

Ludovic Courtès <ludo@gnu.org> writes:

> Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:
>
>> From 0796e8be05977e6d30eab787a1550bd8d1f12b2d Mon Sep 17 00:00:00 2001
>> From: Ben Woodcroft <donttrustben@gmail.com>
>> Date: Sat, 12 Sep 2015 22:10:20 +1000
>> Subject: [PATCH] gnu: Add mafft.
>>
>> * gnu/packages/bioinformatics.scm (mafft): New variable.
>
> I’ll leave it to Ricardo, but two minor comments:

My apologies for the delay.  I flagged this email (along with a couple
of others) as important but it was drowned out by a stream of other
“important” emails... Bleh.

> Maybe not a blocker, but I would really prefer to patterns to be literal
> strings.  If they are too long, we can always split the literal over two
> lines:
>
>     "like \
> this"

I’ve corrected the indentation for the phases and split the string
literals where appropriate instead of using ‘string-append’.

>
>> +   (license (license:non-copyleft "file://license"
>> +                                  "See license in the distribution."))))
>
> I think this should be something like:
>
>   (license (license:non-copyleft
>              "http://mafft.cbrc.jp/alignment/software/license.txt"
>              "BSD-3 with different formatting"))

I replaced the license statement with your suggestion and pushed it.

Thank you, Ben, for the patch and your patience; thank you, Ludo, for
the reviews!

~~ Ricardo