From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: Using 'system*' instead of 'system' in 'guix environment'
Date: Fri, 09 Oct 2015 14:23:22 +0200
Message-ID: <87d1wos01x.fsf@gnu.org>
References: <87io6iqhbt.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
	<87ziztyext.fsf@gnu.org>
	<CAJ=RwfaGBKB1K+kukEXGQTA5eBH_Rov3qJL0esgBu=U0scjyDQ@mail.gmail.com>
	<87vbahpfrn.fsf@gnu.org>
	<CAJ=RwfbpEigt3MRj-wadn=MgXus=wvMPFhbuGnJyh0QAV5Rw1Q@mail.gmail.com>
	<87io6hpaie.fsf@gnu.org>
	<CAJ=Rwfa+Xi-ZLu9L4aw=9BUNb0y1rDRJ3QH=p=kM9qzQtvOREw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47810)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZkWhv-0000FS-2g
	for guix-devel@gnu.org; Fri, 09 Oct 2015 08:23:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZkWhq-0007vt-3l
	for guix-devel@gnu.org; Fri, 09 Oct 2015 08:23:31 -0400
In-Reply-To: <CAJ=Rwfa+Xi-ZLu9L4aw=9BUNb0y1rDRJ3QH=p=kM9qzQtvOREw@mail.gmail.com>
	(David Thompson's message of "Thu, 8 Oct 2015 21:29:39 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: "Thompson, David" <dthompson2@worcester.edu>
Cc: guix-devel <guix-devel@gnu.org>

"Thompson, David" <dthompson2@worcester.edu> skribis:

> From 4be0c2bfd2e2e9a03d860cfb2ff92aa66cbfaa70 Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson2@worcester.edu>
> Date: Thu, 8 Oct 2015 21:23:09 -0400
> Subject: [PATCH] scripts: environment: Use system* instead of system.
>
> This allows for direct program invokation without needing a shell to act
> as a command interpreter.
>
> * guix/scripts/environment.scm (%default-shell): New variable.
>   (show-help): Adjust description.  Remove '--exec' reference.
>   (%default-options): Use '%default-shell'.
>   (%options): Adjust '--exec' to run command via the default shell.
>   (parse-args): New procedure.
>   (guix-environment): Use 'parse-args'.  Use 'system*' instead of
>   'system'.
> * guix/utils.scm (split): New procedure.
> * tests/guix-environment.sh: Adjust tests to use '--' instead of
>   '--exec'.
> * tests/utils.scm: Add tests for 'split'.
> * doc/guix.texi ("Invoking guix environment"): Use new syntax.  Remove
>   '--exec' documentation.

Looks good to me.  Could you just add =E2=80=98split=E2=80=99 in a separate=
 commit?

>           (option '(#\E "exec") #t #f

Add a =E2=80=9Cdeprecated=E2=80=9D comment.

>  # Make sure the exit value is preserved.
> -if guix environment --ad-hoc guile-bootstrap --pure -E 'guile -c "(exit =
42)"'
> +if guix environment --ad-hoc guile-bootstrap --pure -- guile -c '(exit 4=
2)'

Could you keep the example with -E, in addition to the new one, with a
comment noting that this is the deprecated syntax?  We=E2=80=99ll remove it=
 when
we finally remove -E.

OK with these changes, thank you!

Ludo=E2=80=99.