From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul van der Walt Subject: Re: [PATCH] gnu: Add xcompmgr Date: Fri, 23 Oct 2015 15:13:43 +0200 Message-ID: <87d1w5ohh4.fsf@denknerd.org> References: <87si517rav.fsf@SIRIUSGUIX00.i-did-not-set--mail-host-address--so-tickle-me> <87si51or31.fsf@denknerd.org> <87oafpoq8a.fsf@denknerd.org> <87r3kl63ur.fsf@SIRIUSGUIX00.i-did-not-set--mail-host-address--so-tickle-me> Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpcAK-0005QE-BZ for guix-devel@gnu.org; Fri, 23 Oct 2015 09:13:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpcAG-0002M3-5z for guix-devel@gnu.org; Fri, 23 Oct 2015 09:13:52 -0400 Received: from mx01.mykolab.com ([95.128.36.1]:47105 helo=mx-out03.mykolab.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpcAF-0002Lk-VU for guix-devel@gnu.org; Fri, 23 Oct 2015 09:13:48 -0400 In-reply-to: <87r3kl63ur.fsf@SIRIUSGUIX00.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Cyrill Schenkel Cc: guix-devel@gnu.org Hey Cyrill, On 2015-10-23 at 16:45, quoth Cyrill Schenkel: >> On 2015-10-23 at 11:46, quoth Paul van der Walt: >>>> + (setenv "NOCONFIGURE" "t") >> >> Does that do what i think it does? If so, why not just use something >> like the following? >> >> (modify-phases %standard-phases >> (delete 'configure) >> ...) > > It does what you think it does. If I did omit it, I'd need to patch the > `autogen.sh` file so that it passes the neccessary parameters to the > configure script and I'd also need to set the neccessary environment > variables. It seems to me that setting the `NOCONFIGURE` environment > variable is by far the simpler solution. Ah, in fact, i misunderstood and thought it did something else :). I blame my ambiguous communication. I thought it would simply make the configure script not run, at all. Of course, that makes no sense. The parameter seems to stop *autogen.sh* from running `configure`, which is reasonable, since gnu-build-system will do so with the right parameters. Your version seems right indeed, i was simply confused; sorry about that! Cheers, p.