From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Fix subread on non-x86_64
Date: Mon, 26 Oct 2015 15:45:11 +0100
Message-ID: <87d1w14rk8.fsf@gnu.org>
References: <idja8r9yds0.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48798)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zqj1S-0004qb-2i
	for guix-devel@gnu.org; Mon, 26 Oct 2015 10:45:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zqj1N-0007Mz-Pu
	for guix-devel@gnu.org; Mon, 26 Oct 2015 10:45:18 -0400
In-Reply-To: <idja8r9yds0.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Fri, 23 Oct 2015 14:23:27 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> the attached patch should fix the build of subread on non-x86_64 by
> overriding the CC and CCFLAGS variables, which by default are set to
> contain a lot of x86_64 optimisations.

Nice!  Could you add a comment explaining that?

> From 71a37b56d0962f0db4009bdb6a88c22025278a00 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Fri, 23 Oct 2015 14:16:27 +0200
> Subject: [PATCH] gnu: subread: Use SSE optimizations on x86_64 only.
>
> * gnu/packages/bioinformatics.scm (subread)[arguments]: Override CC and
>   CCFLAGS conditionally dependent on target system.

[...]

> +               (if (string-prefix? "x86_64" system)
> +                   (string-append "CCFLAGS=3D" (string-join (append flag=
s flags64) " "))
> +                   (string-append "CCFLAGS=3D" (string-join flags " "))))

The last argument to =E2=80=98string-join=E2=80=99 can be omitted here.

OK with these two changes.

It may be a good case for =E2=80=98guix challenge=E2=80=99 here: If things =
like
-mtune=3Dnative or FDO creep in, =E2=80=98guix challenge=E2=80=99 is likely=
 to flag them.

Thanks,
Ludo=E2=80=99.