From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Lirzin Subject: Re: [PATCH 07/13] build: Add 'DL' silent rule. Date: Tue, 26 Jan 2016 18:44:18 +0100 Message-ID: <87d1so44nh.fsf@gnu.org> References: <1453666771-16869-1-git-send-email-mthl@gnu.org> <1453666771-16869-8-git-send-email-mthl@gnu.org> <87si1knw49.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO7fJ-0001a1-Sb for guix-devel@gnu.org; Tue, 26 Jan 2016 12:44:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aO7fI-00053n-Ph for guix-devel@gnu.org; Tue, 26 Jan 2016 12:44:29 -0500 In-Reply-To: <87si1knw49.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 26 Jan 2016 17:28:22 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Mathieu Lirzin skribis: > >> * Makefile.am (AM_V_DL, AM_V_DL_, AM_V_DL_0): New variables. >> * gnu-system.am (gnu/packages/bootstrap/x86_64-linux/guile-2.0.9.tar.xz) >> (gnu/packages/bootstrap/i686-linux/guile-2.0.9.tar.xz) >> (gnu/packages/bootstrap/armhf-linux/guile-2.0.11.tar.xz) >> (gnu/packages/bootstrap/mips64el-linux/guile-2.0.9.tar.xz): Use $(AM_V_D= L). > > Since downloading is pretty unusual and unexpected (understandably so), > I wonder if we should it leave this one as noisy as it is so that people > see the name of the script that downloads the thing and inspect it. > > WDYT? Indeed, this is unusual and should be avoided in a =E2=80=9Cnormal=E2=80=9D= make context. However I am not sure about the effect of noise in such case: --8<---------------cut here---------------start------------->8--- /bin/mkdir -p `dirname "gnu/packages/bootstrap/mips64el-linux/guile-2.0.9.t= ar.xz"` GUILE_LOAD_COMPILED_PATH=3D".:$GUILE_LOAD_COMPILED_PATH" /usr/bin/guile --n= o-auto-compile -L "." -L "." "./build-aux/download.scm" "gnu/packages/boots= trap/mips64el-linux/guile-2.0.9.tar.xz" "994680f0001346864aa2c2cc5110f380ee= 7518dcd701c614291682b8e948f73b" downloading file `gnu/packages/bootstrap/mips64el-linux/guile-2.0.9.tar.xz'= from `http://alpha.gnu.org/gnu/guix/bootstrap/mips64el-linux/20131110/guil= e-2.0.9.tar.xz'... --8<---------------cut here---------------end--------------->8--- this can easily be overlooked as =E2=80=9Canother=E2=80=9D compilation warn= ing produced by Guile. --8<---------------cut here---------------start------------->8--- DL gnu/packages/bootstrap/i686-linux/guile-2.0.9.tar.xz --8<---------------cut here---------------end--------------->8--- IMO =E2=80=9CDL=E2=80=9D is explicit enough since the target name is a tarb= all and a simple search for the target name in the Makefile gives the actual command. We could use the full word =E2=80=9CDOWNLOAD=E2=80=9D instead of = =E2=80=9CDL=E2=80=9D but on the other hand this will visually blend with the =E2=80=9CLOAD=E2=80=9D for= guile modules. -- Mathieu Lirzin