From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: emacs-pdf-tools: Add missing input.
Date: Tue, 15 Mar 2016 15:27:16 +0100
Message-ID: <87d1qvrf3v.fsf@gnu.org>
References: <87vb4tnyxe.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47520)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1afpwQ-0006hA-OC
	for guix-devel@gnu.org; Tue, 15 Mar 2016 10:27:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1afpwM-0004Yy-Tj
	for guix-devel@gnu.org; Tue, 15 Mar 2016 10:27:22 -0400
In-Reply-To: <87vb4tnyxe.fsf@gmail.com> (Alex Kost's message of "Fri, 11 Mar
	2016 12:31:25 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org

Alex Kost <alezost@gmail.com> skribis:

> The bottom line of the following text is the question: Is it possible to
> combine 2 (or more) build systems for building a package?

Sure!

> I did a little experiment: I thought maybe it could be possible just to
> pick some build phases from (guix build emacs-build-system), so I added
> this module to #:modules and #:imported-modules and added phases like
> this:
>
>   (modify-phases %standard-phases
>     ;; ...
>     (add-after 'build 'emacs-build
>       (@@ (guix build emacs-build-system) build))
>     (add-after 'install 'emacs-install
>       (@@ (guix build emacs-build-system) install)))
>
> The package was built successfully, but the result was not good, because
> both gnu-build-system and emacs-build-system import %standard-phases :-)

You mean =E2=80=9Cexport=E2=80=9D?

I think you can always add a renamer upon import, using something like:

  (package
    ;; =E2=80=A6
    (arguments
     `(#:imported-modules ((guix build emacs-build-system)
                           ,%gnu-build-system-modules)
       #:modules (((guix build emacs-build-system) #:prefix emacs:)
                  ,%gnu-build-system-modules)

       #:phases (modify-phases %standard-phases   ;from gnu-build-system
                  (add-before 'build 'emacs-build
                     (assoc-ref emacs:%standard-phases 'build))
                  ;; =E2=80=A6
                  ))))

Would it work for you?

> From 5692ba83371fea16a34ff20d1f5d743f05173348 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Fri, 11 Mar 2016 11:34:20 +0300
> Subject: [PATCH] gnu: emacs-pdf-tools: Add missing input.
>
> This is a followup to commit eccd0b57a1f05b3caca28604f4d2c06556e2fe05.
>
> * gnu/packages/emacs.scm (emacs-pdf-tools)[propagated-inputs]: Add
> 'let-alist'.
> [arguments]: Adjust 'install-lisp' phase to compile pdf-tools using
> let-alist library.

Otherwise the patch LGTM.

Ludo=E2=80=99.