From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCHES] Upgrade Kodi to 16.0 Date: Tue, 15 Mar 2016 17:17:06 +0100 Message-ID: <87d1qvn2bh.fsf@gnu.org> References: <8760wrip2v.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> <87pouzfoeg.fsf@gnu.org> <87vb4q4top.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afrei-0007dw-Ar for guix-devel@gnu.org; Tue, 15 Mar 2016 12:17:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afree-0006hC-UE for guix-devel@gnu.org; Tue, 15 Mar 2016 12:17:12 -0400 In-Reply-To: (David Thompson's message of "Mon, 14 Mar 2016 15:14:21 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: "Thompson, David" Cc: guix-devel "Thompson, David" skribis: > On Sun, Mar 13, 2016 at 5:24 AM, Ricardo Wurmus wrot= e: >> >> Thompson, David writes: >> >>> Hello Mathieu, >>> >>> On Sat, Mar 12, 2016 at 3:10 PM, Mathieu Lirzin wrote: >>>> Hello David, >>>> >>>> David Thompson writes: >>>> >>>>>>From 80f08dde121610dcc832f4e6ecdd11341166580c Mon Sep 17 00:00:00 2001 >>>>> From: David Thompson >>>>> Date: Sat, 12 Mar 2016 12:23:47 -0500 >>>>> Subject: [PATCH 1/3] gnu: Add crossguid. >>>>> >>>>> * gnu/packages/kodi.scm (crossguid): New variable. >>>>> --- >>>> [...] >>>>> +(define-public crossguid >>>>> + (let ((commit "8f399e8bd4252be9952f3dfa8199924cc8487ca4")) >>>>> + (package >>>>> + (name "crossguid") >>>>> + (version (string-append "0.0-1." (string-take commit 7))) >>>>> + ;; There's no official release. Just a Git repository. >>>>> + (source (origin >>>>> + (method git-fetch) >>>>> + (uri (git-reference >>>>> + (url "https://github.com/graeme-hill/crossguid= .git") >>>>> + (commit commit))) >>>>> + (sha256 >>>>> + (base32 >>>>> + "1i29y207qqddvaxbn39pk2fbh3gx8zvdprfp35wasj9rw2wjk= 3s9")))) >>>> >>>> You have omitted =E2=80=9C(file-name (string-append name "-" version "= .tar.gz"))=E2=80=9D. >>> >>> Not in this case because it's a git checkout, not a tarball download. >> >> Shouldn=E2=80=99t it be named =E2=80=9C...-checkout=E2=80=9D then? We d= o this a lot in the >> bioinformatics.scm module. The default name is just =E2=80=98/gnu/store/=E2=80=A6-git-checkout=E2=80= =99, so you=E2=80=99d have to write: (file-name (string-append name "-" version "-checkout")) See for instance =E2=80=98emacs-undo-tree=E2=80=99. OK with this change. Thank you! Ludo=E2=80=99.