From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] emacs: Use 'build-and-use-profile' from (guix scripts package). Date: Wed, 06 Apr 2016 01:04:29 +0300 Message-ID: <87d1q3soeq.fsf@gmail.com> References: <87egazdjue.fsf@gmail.com> <877fgcv0k9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anZ5O-0002DT-Gl for guix-devel@gnu.org; Tue, 05 Apr 2016 18:04:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anZ5J-0002y7-FG for guix-devel@gnu.org; Tue, 05 Apr 2016 18:04:34 -0400 In-Reply-To: <877fgcv0k9.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 05 Apr 2016 11:59:02 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s (2016-04-05 12:59 +0300) wrote: > Alex Kost skribis: > >> This is to remove code duplication in "emacs/guix-main.scm" and >> "guix/scripts/package.scm" ('build-and-use-profile' did not exist until >> commits 1b67644 and d1ac5c0). >> >> The only important (or maybe not) difference is: >> >> (set-guile-for-build (default-guile)) >> >> in "guix-main.scm" which does not exist in 'build-and-use-profile'. It >> was introduced in commit 4ad2e76 and I don't really understand why it is >> needed. > > For future reference, this was(?) needed because =E2=80=98run-with-store= =E2=80=99 has > its #:guile parameter default to (%guile-for-build), which itself > defaults to #f (4ad2e76 and e87f059 hint at this.) > > I presume that somehow =E2=80=98%guile-for-build=E2=80=99 or #:guile gets= the right > value in this case. Thanks for the info! I already pushed this patch, and I have not had any problems with it so far. Let's see if it will introduced bugs or not :-) --=20 Alex