unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex Kost <alezost@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] emacs: Use 'build-and-use-profile' from (guix scripts package).
Date: Wed, 06 Apr 2016 01:04:29 +0300	[thread overview]
Message-ID: <87d1q3soeq.fsf@gmail.com> (raw)
In-Reply-To: <877fgcv0k9.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 05 Apr 2016 11:59:02 +0200")

Ludovic Courtès (2016-04-05 12:59 +0300) wrote:

> Alex Kost <alezost@gmail.com> skribis:
>
>> This is to remove code duplication in "emacs/guix-main.scm" and
>> "guix/scripts/package.scm" ('build-and-use-profile' did not exist until
>> commits 1b67644 and d1ac5c0).
>>
>> The only important (or maybe not) difference is:
>>
>>   (set-guile-for-build (default-guile))
>>
>> in "guix-main.scm" which does not exist in 'build-and-use-profile'.  It
>> was introduced in commit 4ad2e76 and I don't really understand why it is
>> needed.
>
> For future reference, this was(?) needed because ‘run-with-store’ has
> its #:guile parameter default to (%guile-for-build), which itself
> defaults to #f (4ad2e76 and e87f059 hint at this.)
>
> I presume that somehow ‘%guile-for-build’ or #:guile gets the right
> value in this case.

Thanks for the info!  I already pushed this patch, and I have not had
any problems with it so far.  Let's see if it will introduced bugs or
not :-)

-- 
Alex

      reply	other threads:[~2016-04-05 22:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-25  8:48 [PATCH] emacs: Use 'build-and-use-profile' from (guix scripts package) Alex Kost
2016-04-05  9:59 ` Ludovic Courtès
2016-04-05 22:04   ` Alex Kost [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1q3soeq.fsf@gmail.com \
    --to=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).