From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] gnu: asymptote: Install Emacs data Date: Sun, 08 May 2016 11:58:04 +0300 Message-ID: <87d1oxgc4j.fsf@gmail.com> References: <87inyqbvf2.fsf@saiph.selenimh> <87posy7089.fsf@gmail.com> <871t5eav7f.fsf@saiph.selenimh> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azKXQ-0006Zk-2u for guix-devel@gnu.org; Sun, 08 May 2016 04:58:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azKXL-0003HI-Pn for guix-devel@gnu.org; Sun, 08 May 2016 04:58:06 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:35479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azKXL-0003HD-GW for guix-devel@gnu.org; Sun, 08 May 2016 04:58:03 -0400 Received: by mail-lf0-x244.google.com with SMTP id u64so17935426lff.2 for ; Sun, 08 May 2016 01:58:03 -0700 (PDT) In-Reply-To: <871t5eav7f.fsf@saiph.selenimh> (Nicolas Goaziou's message of "Sat, 07 May 2016 14:50:12 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Nicolas Goaziou Cc: guix-devel@gnu.org Nicolas Goaziou (2016-05-07 15:50 +0300) wrote: > Hello, > > Alex Kost writes: > >> Thanks! Sorry I didn't build asymptote (as I don't have a wish to build >> gigabytes of texlive), but I looked at the source and I see there are >> "autoloads" cookies in "/base/asy-mode.el", so it would also >> be good to generate "asymptote-autoloads.el" file. > > Indeed. > >> For example, you may look at (gnu packages emacs) module to see how >> "autoloads" file are generated using 'emacs-generate-autoloads' >> procedure. I write some notes below, that seems appropriate to me, but >> I'm not going to test the patch because of texlive (sorry again). I >> hope other people will do. > > Fair enough. > > Here is an updated patch with suggested changes. Thank you for the review. Thanks! Looks good to me, so if there will be no other comments in several days, I will commit it. Did you check that the resulting "/share/emacs/site-lisp" directory contains elisp files (including "asymptote-autoloads.el")? -- Alex