[PATCH] gnu: Add libytnef.

[PATCH] gnu: Add libytnef.

[Kei Yamashita]

[-- Attachment #1.1: Type: text/plain, Size: 31 bytes --]

Another Evolution dependency.

[-- Attachment #1.2: 0001-gnu-Add-libytnef.patch --]
[-- Type: text/plain, Size: 1690 bytes --]

From ef59448eb47ea1a6ec27d953e7903d83a76a7fe6 Mon Sep 17 00:00:00 2001
From: Kei Yamashita <kei@openmailbox.org>
Date: Tue, 10 May 2016 22:05:49 -0400
Subject: [PATCH] gnu: Add libytnef.

* gnu/packages/mail.scm (libytnef): New variable.
---
 gnu/packages/mail.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 2d95753..a8e8716 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -1232,3 +1232,25 @@ the 64 bit Outlook 2003 pst files.  Utilities are supplied to convert email
 messages to both mbox and MH mailbox formats.  Contacts can be converted to a
 simple list, to vcard format, or to ldif format for import to an LDAP server.")
     (license gpl2+)))
+
+(define-public libytnef
+  (package
+    (name "libytnef")
+    (version "1.5")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://sourceforge/ytnef/"
+                                  name "/" version "/" name
+                                  "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "0bkmw5sypwbyrawbb66pkc7d6crck529bs0p36j42z045vja28hv"))))
+    (build-system gnu-build-system)
+    (home-page "https://github.com/Yeraze/ytnef")
+    (synopsis "Decodes TNEF streams")
+    (description
+     "ytnef is a program to decode TNEF streams (winmail.dat).  Unlike other
+similar programs, it can also decode meeting requests and create VCal entries
+for easy import.  It can also create vCard entries from contact cards and vTodo
+entries from task entries.")
+    (license gpl2)))
-- 
2.7.4


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH] gnu: Add libytnef.

[Eric Bavier]

On Tue, 10 May 2016 22:14:27 -0400
Kei Yamashita <kei@openmailbox.org> wrote:

> * gnu/packages/mail.scm (libytnef): New variable.
> ---
>  gnu/packages/mail.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
> index 2d95753..a8e8716 100644
> --- a/gnu/packages/mail.scm
> +++ b/gnu/packages/mail.scm
> @@ -1232,3 +1232,25 @@ the 64 bit Outlook 2003 pst files.  Utilities are supplied to convert email
>  messages to both mbox and MH mailbox formats.  Contacts can be converted to a
>  simple list, to vcard format, or to ldif format for import to an LDAP server.")
>      (license gpl2+)))
> +
> +(define-public libytnef
> +  (package
> +    (name "libytnef")
> +    (version "1.5")

The latest git source at https://github.com/Yeraze/ytnef has fixes for
several bugs, segfaults, and memory leaks.  The configure.ac there notes
version 1.7, but I don't see any release tarballs.  Could you maybe
pester the maintainer to make a release?

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://sourceforge/ytnef/"
> +                                  name "/" version "/" name
> +                                  "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0bkmw5sypwbyrawbb66pkc7d6crck529bs0p36j42z045vja28hv"))))
> +    (build-system gnu-build-system)
> +    (home-page "https://github.com/Yeraze/ytnef")
> +    (synopsis "Decodes TNEF streams")

How about "Mail stream decoder" instead?  See section "Synopses and
Descriptions" in the manual.

> +    (description
> +     "ytnef is a program to decode TNEF streams (winmail.dat).  Unlike other
> +similar programs, it can also decode meeting requests and create VCal entries
> +for easy import.  It can also create vCard entries from contact cards and vTodo
> +entries from task entries.")
> +    (license gpl2)))

This should be gpl2+, since the source headers contain the "or later"
verbiage.

Otherwise LGTM.  Could you send an updated patch?
`~Eric

Re: [PATCH] gnu: Add libytnef.

[Kei Yamashita]

[-- Attachment #1.1: Type: text/plain, Size: 2432 bytes --]

On Wed, 11 May 2016 09:24:25 -0500
Eric Bavier <ericbavier@openmailbox.org> wrote:

> On Tue, 10 May 2016 22:14:27 -0400
> Kei Yamashita <kei@openmailbox.org> wrote:
> 
> > * gnu/packages/mail.scm (libytnef): New variable.
> > ---
> >  gnu/packages/mail.scm | 22 ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> > 
> > diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
> > index 2d95753..a8e8716 100644
> > --- a/gnu/packages/mail.scm
> > +++ b/gnu/packages/mail.scm
> > @@ -1232,3 +1232,25 @@ the 64 bit Outlook 2003 pst files.
> > Utilities are supplied to convert email messages to both mbox and
> > MH mailbox formats.  Contacts can be converted to a simple list, to
> > vcard format, or to ldif format for import to an LDAP server.")
> > (license gpl2+))) +
> > +(define-public libytnef
> > +  (package
> > +    (name "libytnef")
> > +    (version "1.5")  
> 
> The latest git source at https://github.com/Yeraze/ytnef has fixes for
> several bugs, segfaults, and memory leaks.  The configure.ac there
> notes version 1.7, but I don't see any release tarballs.  Could you
> maybe pester the maintainer to make a release?
> 
> > +    (source (origin
> > +              (method url-fetch)
> > +              (uri (string-append "mirror://sourceforge/ytnef/"
> > +                                  name "/" version "/" name
> > +                                  "-" version ".tar.gz"))
> > +              (sha256
> > +               (base32
> > +
> > "0bkmw5sypwbyrawbb66pkc7d6crck529bs0p36j42z045vja28hv"))))
> > +    (build-system gnu-build-system)
> > +    (home-page "https://github.com/Yeraze/ytnef")
> > +    (synopsis "Decodes TNEF streams")  
> 
> How about "Mail stream decoder" instead?  See section "Synopses and
> Descriptions" in the manual.
> 
> > +    (description
> > +     "ytnef is a program to decode TNEF streams (winmail.dat).
> > Unlike other +similar programs, it can also decode meeting requests
> > and create VCal entries +for easy import.  It can also create vCard
> > entries from contact cards and vTodo +entries from task entries.")
> > +    (license gpl2)))  
> 
> This should be gpl2+, since the source headers contain the "or later"
> verbiage.
> 
> Otherwise LGTM.  Could you send an updated patch?
> `~Eric

Updated as requested. Also, I'll see about building libytnef from
within the github tree if possible.

[-- Attachment #1.2: 0001-gnu-Add-libytnef.patch --]
[-- Type: text/plain, Size: 1958 bytes --]

From 1b6f995092a144b20698b0b24911f06b352cab50 Mon Sep 17 00:00:00 2001
From: Kei Yamashita <kei@openmailbox.org>
Date: Thu, 12 May 2016 00:44:48 -0400
Subject: [PATCH] gnu: Add libytnef.

* gnu/packages/mail.scm (libytnef): New variable.
---
 gnu/packages/mail.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 13749aa..da8e8df 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -13,6 +13,7 @@
 ;;; Copyright © 2016 Al McElrath <hello@yrns.org>
 ;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
 ;;; Copyright © 2016 Lukas Gradl <lgradl@openmailbox.org>
+;;; Copyright © 2016 Kei Yamashita <kei@openmailbox.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1203,3 +1204,25 @@ synchronizing with a remote address book, @command{vdirsyncer} is recommended.
 Khard can also be used from within the email client @command{mutt}.")
     (home-page "https://github.com/scheibler/khard")
     (license gpl3+)))
+
+(define-public libytnef
+  (package
+    (name "libytnef")
+    (version "1.5")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://sourceforge/ytnef/"
+                                  name "/" version "/" name
+                                  "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "0bkmw5sypwbyrawbb66pkc7d6crck529bs0p36j42z045vja28hv"))))
+    (build-system gnu-build-system)
+    (home-page "https://github.com/Yeraze/ytnef")
+    (synopsis "Mail stream decoder")
+    (description
+     "ytnef is a program to decode TNEF streams (winmail.dat).  Unlike other
+similar programs, it can also decode meeting requests and create VCal entries
+for easy import.  It can also create vCard entries from contact cards and vTodo
+entries from task entries.")
+    (license gpl2+)))
-- 
2.7.4


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH] gnu: Add libytnef.

[Ludovic Courtès]

Kei Yamashita <kei@openmailbox.org> skribis:

> On Wed, 11 May 2016 09:24:25 -0500
> Eric Bavier <ericbavier@openmailbox.org> wrote:

[...]

>> This should be gpl2+, since the source headers contain the "or later"
>> verbiage.
>> 
>> Otherwise LGTM.  Could you send an updated patch?
>> `~Eric
>
> Updated as requested. Also, I'll see about building libytnef from
> within the github tree if possible.
>
> From 1b6f995092a144b20698b0b24911f06b352cab50 Mon Sep 17 00:00:00 2001
> From: Kei Yamashita <kei@openmailbox.org>
> Date: Thu, 12 May 2016 00:44:48 -0400
> Subject: [PATCH] gnu: Add libytnef.
>
> * gnu/packages/mail.scm (libytnef): New variable.

Now is a good time to test your Git access: please push!

Thanks,
Ludo’.