[PATCH] gnu: Add python2-pydns

[PATCH] gnu: Add python2-pydns

[Danny Milosavljevic]

* gnu/packages/networking.scm (python2-pydns): New variable.
---
 gnu/packages/networking.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index f89a73e..616d616 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -30,6 +30,7 @@
   #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system perl)
+  #:use-module (guix build-system python)
   #:use-module (gnu packages admin)
   #:use-module (gnu packages adns)
   #:use-module (gnu packages audio)
@@ -607,3 +608,25 @@ offline emulation of DNS.")
   (description "The Perl module 'Geo::IP'.
 It looks up location and network information by IP Address.")
   (license (package-license perl))))
+
+(define-public python2-pydns
+ (package
+  (name "python2-pydns")
+  (version "2.3.6")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (pypi-uri "pydns" version))
+      (sha256
+        (base32
+          "0qnv7i9824nb5h9psj0rwzjyprwgfiwh5s5raa9avbqazy5hv5pi"))))
+  (build-system python-build-system)
+  (native-inputs
+    `(("python2-setuptools" ,python2-setuptools)))
+  (arguments
+    `(#:tests? #f #| there are no tests |#
+      #:python ,python-2))
+  (home-page "http://pydns.sourceforge.net/")
+  (synopsis "Python DNS library")
+  (description "Python DNS library")
+  (license license:psfl)))

Re: [PATCH] gnu: Add python2-pydns

[Leo Famulari]

On Wed, Jul 27, 2016 at 02:35:28AM +0200, Danny Milosavljevic wrote:
> * gnu/packages/networking.scm (python2-pydns): New variable.

Thanks for this patch!

> @@ -607,3 +608,25 @@ offline emulation of DNS.")
>    (description "The Perl module 'Geo::IP'.
>  It looks up location and network information by IP Address.")
>    (license (package-license perl))))
> +
> +(define-public python2-pydns

It doesn't apply to the current master branch. Can you regenerate it and
make sure it applies?

> +  (arguments
> +    `(#:tests? #f #| there are no tests |#
> +      #:python ,python-2))

Does it only work with python-2? If so, we can add a comment saying so.
Otherwise, let's package both versions.

Re: [PATCH] gnu: Add python2-pydns

[Ludovic Courtès]

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> +  (arguments
> +    `(#:tests? #f #| there are no tests |#

In addition to Leo’s comment: please avoid #| comments; they are not
used anywhere and I think we can happily avoid them.  :-)

Thanks,
Ludo’.