unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ng0 <ng0@we.make.ritual.n0.is>
To: Marius Bakke <mbakke@fastmail.com>, guix-devel@gnu.org
Subject: Re: [PATCH] gnu: slim: Move to display-managers.scm.
Date: Wed, 31 Aug 2016 13:49:35 +0000	[thread overview]
Message-ID: <87d1kpm4k0.fsf@we.make.ritual.n0.is> (raw)
In-Reply-To: <8760qhysz9.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me>

Marius Bakke <mbakke@fastmail.com> writes:

> Hi,
>
> This change is to make room for SDDM and other display managers such as
> lightdm.
>
> I did not add a copyright line as I consider "git mv" a trivial
> operation.
>
> From a7e59cb154bd11e7ca04f68753982b21bef22b10 Mon Sep 17 00:00:00 2001
> From: Marius Bakke <mbakke@fastmail.com>
> Date: Wed, 31 Aug 2016 14:07:15 +0100
> Subject: [PATCH] gnu: slim: Move to display-managers.scm.
>
> * gnu/packages/display-managers.scm: New file.
> * gnu/packages/slim.scm: Delete file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Adjust accordingly.
> * gnu/services/xorg.scm: Likewise.
> ---
>  gnu/local.mk                                    | 2 +-
>  gnu/packages/{slim.scm => display-managers.scm} | 2 +-
>  gnu/services/xorg.scm                           | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>  rename gnu/packages/{slim.scm => display-managers.scm} (98%)
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 5ec47fc..bc34e4a 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -96,6 +96,7 @@ GNU_SYSTEM_MODULES =				\
>    %D%/packages/dictionaries.scm			\
>    %D%/packages/dillo.scm			\
>    %D%/packages/disk.scm				\
> +  %D%/packages/display-managers.scm		\
>    %D%/packages/djvu.scm				\
>    %D%/packages/dns.scm				\
>    %D%/packages/docbook.scm			\
> @@ -320,7 +321,6 @@ GNU_SYSTEM_MODULES =				\
>    %D%/packages/skarnet.scm			\
>    %D%/packages/skribilo.scm			\
>    %D%/packages/slang.scm			\
> -  %D%/packages/slim.scm				\
>    %D%/packages/smalltalk.scm			\
>    %D%/packages/speech.scm			\
>    %D%/packages/spice.scm			\
> diff --git a/gnu/packages/slim.scm b/gnu/packages/display-managers.scm
> similarity index 98%
> rename from gnu/packages/slim.scm
> rename to gnu/packages/display-managers.scm
> index 2328a1a..579b149 100644
> --- a/gnu/packages/slim.scm
> +++ b/gnu/packages/display-managers.scm
> @@ -18,7 +18,7 @@
>  ;;; You should have received a copy of the GNU General Public License
>  ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
>  
> -(define-module (gnu packages slim)
> +(define-module (gnu packages display-managers)
>    #:use-module ((guix licenses) #:prefix l:)
>    #:use-module (guix packages)
>    #:use-module (guix download)
> diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm
> index 905c88f..4e311de 100644
> --- a/gnu/services/xorg.scm
> +++ b/gnu/services/xorg.scm
> @@ -26,7 +26,7 @@
>    #:use-module (gnu packages guile)
>    #:use-module (gnu packages xorg)
>    #:use-module (gnu packages gl)
> -  #:use-module (gnu packages slim)
> +  #:use-module (gnu packages display-managers)
>    #:use-module (gnu packages gnustep)
>    #:use-module (gnu packages admin)
>    #:use-module (gnu packages bash)
> -- 
> 2.9.3
>

I did not apply this, but it looks good to me in regards of not breaking
anything:

ng0@shadowwalker ~$ cd src/guix/guix-no-changes/
ng0@shadowwalker ~/src/guix/guix-no-changes$ egrep -nr "gnu packages slim"
gnu/packages/slim.scm:21:(define-module (gnu packages slim)
gnu/services/xorg.scm:29:  #:use-module (gnu packages slim)

-- 
ng0
For non-prism friendly talk find me on http://www.psyced.org

      parent reply	other threads:[~2016-08-31 13:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-31 13:21 [PATCH] gnu: slim: Move to display-managers.scm Marius Bakke
2016-08-31 13:41 ` David Craven
2016-08-31 13:52   ` Marius Bakke
2016-09-01 11:56   ` Ludovic Courtès
2016-09-01 13:27     ` David Craven
2016-08-31 13:49 ` ng0 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1kpm4k0.fsf@we.make.ritual.n0.is \
    --to=ng0@we.make.ritual.n0.is \
    --cc=guix-devel@gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).