From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH 3/4] gnu: Add psyclpc. Date: Sun, 30 Oct 2016 07:03:48 +0100 Message-ID: <87d1ii9xvf.fsf@mdc-berlin.de> References: <20160929103810.10273-1-ngillmann@runbox.com> <20160929103810.10273-3-ngillmann@runbox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0jDr-0004w8-VF for guix-devel@gnu.org; Sun, 30 Oct 2016 02:04:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c0jDo-0000Z7-RI for guix-devel@gnu.org; Sun, 30 Oct 2016 02:03:59 -0400 Received: from sinope02.bbbm.mdc-berlin.de ([141.80.25.24]:57489) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c0jDo-0000Yh-Jn for guix-devel@gnu.org; Sun, 30 Oct 2016 02:03:56 -0400 In-Reply-To: <20160929103810.10273-3-ngillmann@runbox.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org ng0 writes: > * gnu/packages/psyc.scm (psyclpc): New variable. > --- > gnu/packages/psyc.scm | 79 +++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 1 file changed, 79 insertions(+) > > diff --git a/gnu/packages/psyc.scm b/gnu/packages/psyc.scm As before, please add this to =E2=80=9Cmessaging=E2=80=9D. > + > +;; This commit removes the historic bundled pcre, not released as a ta= rball so far. > +(define-public psyclpc > + (let* ((commit "8bd51f2a4847860ba8b82dc79348ab37d516011e") > + (revision "1")) Okay. > + (package > + (name "psyclpc") > + (version (string-append "20160821-" revision "." (string-take comm= it 7))) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "git://git.psyced.org/git/psyclpc") > + (commit commit))) > + (sha256 > + (base32 > + "10w4kx9ygcv1lcmd7j4knvjiy8dac1y3hjfv3lhp67jpv6w3iagz"= )))) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f ; There are no tests/checks. > + #:configure-flags > + ;; If you have questions about this part, look at > + ;; "src/settings/psyced" and the ebuild. Please don=E2=80=99t do this. Guix is not a derivative of Gentoo. This = should be explained right here. > + (list > + "--enable-use-tls=3Dyes" > + "--enable-use-mccp" ; Mud Client Compression Protocol, leave t= his enabled. > + (string-append "--prefix=3D" > + (assoc-ref %outputs "out")) > + ;; src/Makefile: Set MUD_LIB to the directory which contains > + ;; the mud data. defaults to MUD_LIB =3D @libdir@ > + (string-append "--libdir=3D" > + (assoc-ref %outputs "out") > + "/opt/psyced/world") > + (string-append "--bindir=3D" > + (assoc-ref %outputs "out") > + "/opt/psyced/bin") > + ;; src/Makefile: Set ERQ_DIR to directory which contains the > + ;; stuff which ERQ can execute (hopefully) savely. Was former= ly > + ;; defined in config.h. defaults to ERQ_DIR=3D @libexecdir@ > + (string-append "--libexecdir=3D" > + (assoc-ref %outputs "out") > + "/opt/psyced/run")) I don=E2=80=99t think it=E2=80=99s wise to override the target directorie= s to have a prefix of =E2=80=9C/opt/psyced=E2=80=9D. We already have a prefix: =E2=80=9C/gnu/store/--/=E2=80=9D. If this is needed= at runtime for some reason it should be done by a service. > + #:phases > + (modify-phases %standard-phases > + (add-before 'configure 'chdir-to-src > + ;; We need to pass this as env variables > + ;; and manually change the directory. What is =E2=80=9Cthis=E2=80=9D? > + (lambda _ > + (chdir "src") > + (setenv "CONFIG_SHELL" (which "sh")) > + (setenv "SHELL" (which "sh"))))) CONFIG_SHELL and SHELL are usually set for autoconf. Why does this not work in this case? Please end the phase with #t. > + #:make-flags (list "install-all"))) > + (inputs > + `(("zlib" ,zlib) > + ("openssl" ,openssl) > + ("pcre" ,pcre))) > + (native-inputs > + `(("pkg-config" ,pkg-config) > + ("bison" ,bison) > + ("gnu-gettext" ,gnu-gettext) > + ("help2man" ,help2man) > + ("autoconf" ,autoconf) > + ("automake" ,automake))) > + (home-page "http://lpc.psyc.eu/") > + (synopsis "psycLPC is a multi-user network server programming > language") s/psycLPC is a// > + (description > + "LPC is a bytecode language, invented to specifically implement > +multi user virtual environments on the internet. This technology is u= sed for > +MUDs and also the psyced implementation of the Protocol for SYnchronou= s Conferencing (PSYC). psycLPC is a fork of LDMud with some new features= and > +many bug fixes.") Please fix the line lengths. > + (license license:gpl2)))) GPLv2 only? ~~ Ricardo