From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add Handbrake.
Date: Sat, 12 Nov 2016 12:37:00 +0100
Message-ID: <87d1i1nd43.fsf@gnu.org>
References: <20161031030822.10785-1-bavier@member.fsf.org>
	<8760o8kh10.fsf@elephly.net> <20161103230833.3fc7e345@centurylink.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45563)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c5WcO-000710-LN
	for guix-devel@gnu.org; Sat, 12 Nov 2016 06:37:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c5WcN-0004nI-UP
	for guix-devel@gnu.org; Sat, 12 Nov 2016 06:37:08 -0500
In-Reply-To: <20161103230833.3fc7e345@centurylink.net> (Eric Bavier's message
	of "Thu, 3 Nov 2016 23:08:33 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Eric Bavier <ericbavier@centurylink.net>
Cc: guix-devel@gnu.org, Eric Bavier <bavier@member.fsf.org>

Eric Bavier <ericbavier@centurylink.net> skribis:

> On Mon, 31 Oct 2016 10:30:40 +0100
> Ricardo Wurmus <rekado@elephly.net> wrote:
>
>> Eric Bavier <bavier@member.fsf.org> writes:
>>=20
>> > * gnu/packages/video.scm (handbrake): New variable.
>> > * gnu/packages/patches/handbrake-pkg-config-path.patch: New patch.
>> > * gnu/local.mk (dist_patch_DATA): Add it.=20=20
>>=20
>> Yay, thanks for the patch!
>
> Thanks for the feedback!  I've incorporated your and Efraim's
> suggestions in the attached patch.=20=20
>
> The resulting Handbrake mostly works, but the default transcoding
> presets and gui icons are missing.  I've done as much as I can to debug
> this, but I can't put any more time into it.  I could commit this
> as-is and fix it later, or someone else could pick it up.

There are other packages with missing icons, I think this can be fixed
separately.

So I=E2=80=99d say you can commit it.

Thank you,
Ludo=E2=80=99.