From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Marusich Subject: Re: java: switch to icedtea-8 as default JDK Date: Tue, 28 Nov 2017 22:48:24 -0800 Message-ID: <87d141mvgn.fsf@gmail.com> References: <87375czhqj.fsf@elephly.net> <873756herx.fsf@gmail.com> <87y3myv7k9.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJwAe-0006WK-5p for guix-devel@gnu.org; Wed, 29 Nov 2017 01:48:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJwAd-0006XG-49 for guix-devel@gnu.org; Wed, 29 Nov 2017 01:48:36 -0500 Received: from mail-pf0-x22e.google.com ([2607:f8b0:400e:c00::22e]:38179) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJwAc-0006Wr-P5 for guix-devel@gnu.org; Wed, 29 Nov 2017 01:48:35 -0500 Received: by mail-pf0-x22e.google.com with SMTP id u25so1137082pfg.5 for ; Tue, 28 Nov 2017 22:48:34 -0800 (PST) In-Reply-To: <87y3myv7k9.fsf@elephly.net> (Ricardo Wurmus's message of "Wed, 22 Nov 2017 13:09:26 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable G=C3=A1bor Boskovits writes: > Hello! > > I just run a quick grep to see which files might be interesting. > > We use ant-build-system in: > axoloti.scm * > bioinformatics.scm * > compression.scm * > icu4c.scm > java.scm * > libusb.scm * > music.scm * > textutlis.scm > uml.scm * > version-control.scm * > web.scm * > xml.scm > > Only the ant-build system uses icedtea among build systems. > > Icedtea is explicitly metioned in the ones maked with *, and: > kodi.scm > math.scm > ruby.scm > > We have a definition in place where currently icedtea is defined to be > icedtea-7. > I guess we could just flip that to icedtea-8, and check what still works. > That would flip the version in the build system also, as it uses "icedtea= ". > > Should I check which packages are affected in advance, or just go with the > build and see what does not work? Another way to check what packages we'll need to try to build is to use "guix refresh", which uses some features of (guix graph) to display information about dependent packages. Here's what we get for icedtea-7: =2D-8<---------------cut here---------------start------------->8--- [0] marusich@garuda.local:~/guix $ ./pre-inst-env guix refresh -l -e '(@ (gnu packages java) icedtea-7)' Building the following 39 packages would ensure 202 dependent packages are = rebuilt: sra-tools@2.8.2-1 minced@0.2.0 r-seurat@1.4.0.12-1.fccb77d ant@1.1= 0.1 java-htsjdk@1.129 java-jdom@1.1.3 clojure@1.8.0 java-osgi-service-jdbc@= 1.0.0 java-plexus-interpolation@1.23 java-commons-daemon@1.0.15 java-common= s-net@3.6 java-commons-cli@1.2 java-commons-lang@2.6 java-jmh@1.17.5 tuxgui= tar@1.4 java-commons-collections4@4.1 java-javax-mail@1.5.6 f-seq@1.1-1.6cc= ded3 java-commons-beanutils@1.9.3 java-jgit@4.7.0.201704051617-r java-osgi-= service-resolver@1.0.1 java-osgi-service-packageadmin@1.2.0 java-osgi-servi= ce-cm@1.5.0 java-osgi-util-tracker@1.5.1 antlr3@3.5.2 java-eclipse-team-cor= e@3.8.0 java-httpcomponents-httpcore-ab@4.4.6 java-httpcomponents-httpmime@= 4.5.3 java-httpcomponents-httpcore-nio@4.4.6 java-plexus-container-default@= 1.7.1 kodi@18.0_alpha-6-f22d62d hdf-java@3.3.2 ruby-atoulme-antwrap@0.7.5 p= lantuml@8048 java-guice-servlet@4.1 java-eclipse-jetty-servlet@9.4.6 java-e= clipse-jetty-servlet@9.2.22 icedtea-web@1.6.2 axoloti-patcher@1.0.12 =2D-8<---------------cut here---------------end--------------->8--- So, I think we should probably do the following: 1) Confirm that these packages build before making changes. If any fail, fix them first if possible. 2) As you suggested, flip the icedtea variable to point to icedtea-8 instead of icedtea-7. 3) Repeat the builds, and see what fails. Fix any new breakage. And of course, we should opportunistically clean up package definitions as we go. I'm going to try step (1) tonight on my laptop. Is there a way to check their build status on Hydra, I wonder? I'm planning to just do it in a simple shell one-liner like the following: =2D-8<---------------cut here---------------start------------->8--- for pkg in $(> /tmp/log; else echo failure: $pkg >> /tmp/log; fi; done =2D-8<---------------cut here---------------end--------------->8--- ...but I'm sure there is probably a more elegant way to accomplish the same task. Anyway, I'll let you know how it goes. > As first step it is not needed to remove #:jdk icedtea-8 references, > because I think that simply becomes a noop. Am I right here? > That can be done as the last step before merging, I guess. I think that's right, but I haven't looked closely yet, and Ricardo may know more. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAloeWDgACgkQ3UCaFdgi Rp1i9g/7BtI6D82BZOg6HZgP6MFpGCW92DVt6Ko4xauY5W+1DTXyNqNYUfdCBXNK JbfEJB4XL3NMu4xyuY9346B+qB4AIiBzJ5VdUOlaW9OmMqAxTjfL0tl9vsT77RuT Bzs2NlmsV7hB5yPyWmoVqQKXD/SBqOCj5oDR75YqY3SO6P+XifTbZX7Zdu2MHoJI sv3kHqnpFGftbOeNVt4uxG4VfSqsm1dZI0qRKzGq1ycda09xBbum5tGyN2+OUIpG hE1pSzn+4NpArAris1EH+omHsr+GTkWyOijW88bvw+w2oqtH+IvlH8LxrjHQYECA 3vJtB8d9zEAfDHGg4HzjTek2QWULOgrYSZ/I8cq2QQdISXYVwWO091E5VMqPoh2x m1RRVjNFHQD6UPqEQ3wd5jVfBT0w2jMveGGkcL/vqQ8o7g7AJZQlW8mXQcZowJdg 2FxexXWMD+vsq9EM7J79+FOA2zDfCV3hk4FT4iqSvkjkG0FjWZ0eHX4lzsXi4/ri 90F+gL/V3x9Qib/JRoIjfOI/VQIHXYqr5brlCFGHxMfDTIFbmlVrhLW4FEzzMwZz Dp8JaX1+b6C0wQr+DRyCGppyof5rL0tnQ7kMAILid0GJSo+/0N0+KLdreOP/kZ1I /PETzt2MdezOU5ZHUhP+QswaAeEMNGJeneWkTd3YKjzAsnsl2Qo= =dwsw -----END PGP SIGNATURE----- --=-=-=--