unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: guix-devel@gnu.org
Subject: Re: 01/02: Revert "gnu: openssh: Clean-up custom install phase."
Date: Thu, 27 Jun 2019 01:52:37 -0400	[thread overview]
Message-ID: <87d0izr2vu.fsf@netris.org> (raw)
In-Reply-To: <20190626222130.F3AE520A01@vcs0.savannah.gnu.org> (guix-commits's message of "Wed, 26 Jun 2019 18:21:30 -0400 (EDT)")

Hi Tobias,

guix-commits@gnu.org writes:

> nckx pushed a commit to branch master
> in repository guix.
>
> commit 1ebb908d447fd7e641e800f970a0035ccd98deb7
> Author: Tobias Geerinckx-Rice <me@tobias.gr>
> Date:   Thu Jun 27 00:20:50 2019 +0200
>
>     Revert "gnu: openssh: Clean-up custom install phase."
>
>     This reverts commit 7754136e464e02284624ad05c196d9ec26099143.

and you reverted another commit related to openssh as well:

> commit ba912479e8481d69b699ce348b35d5d70f0c9367
> Author: Tobias Geerinckx-Rice <me@tobias.gr>
> Date:   Thu Jun 27 00:20:54 2019 +0200
>
>     Revert "gnu: openssh: Don't create the PRIVSEP_PATH directory."
>
>     This reverts commit 46475f72ab6127e7818fdea4a0ea9cc07c60a5f4.

I don't doubt that reverting these commits was the right thing to do,
but it would be good to know _why_ they were reverted.  Can you provide
a link to a relevant discussion, or else explain it here?

In general, when reverting commits, I think it would be useful to
include an explanation in the commit log.  What do you think?

    Regards,
      Mark

       reply	other threads:[~2019-06-27  5:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190626222130.32023.24888@vcs0.savannah.gnu.org>
     [not found] ` <20190626222130.F3AE520A01@vcs0.savannah.gnu.org>
2019-06-27  5:52   ` Mark H Weaver [this message]
2019-06-27  6:16     ` 01/02: Revert "gnu: openssh: Clean-up custom install phase." Tobias Geerinckx-Rice
2019-06-27  6:39       ` Mark H Weaver
2019-06-27  6:52         ` Tobias Geerinckx-Rice
2019-06-27  8:05       ` Jonathan Brielmaier
2019-06-27 15:57     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0izr2vu.fsf@netris.org \
    --to=mhw@netris.org \
    --cc=guix-devel@gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).