From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timothy Sample Subject: Re: haskell changes Date: Sun, 18 Aug 2019 21:09:30 -0400 Message-ID: <87d0h22c6t.fsf@ngyro.com> References: <32F0A261-9B71-48C8-8DEE-F7A56C96230C@vllmrt.net> <87imqw3lyf.fsf@ngyro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:34891) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzWAy-0001d7-Jr for guix-devel@gnu.org; Sun, 18 Aug 2019 21:09:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzWAw-0001ml-Af for guix-devel@gnu.org; Sun, 18 Aug 2019 21:09:36 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:33919) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hzWAv-0001lD-T4 for guix-devel@gnu.org; Sun, 18 Aug 2019 21:09:34 -0400 In-Reply-To: <87imqw3lyf.fsf@ngyro.com> (Timothy Sample's message of "Fri, 16 Aug 2019 16:16:24 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Robert Vollmert Cc: guix-devel@gnu.org Hi Robert, Timothy Sample writes: > Robert Vollmert writes: > >> I have some Haskell-related changes ready for review and ideally merge >> on wip-haskell-updates. > > Sounds good. I=E2=80=99ll take a look at that branch soon. > >> Changes are: >> 1. move libraries out of haskell.scm (mostly into haskell-xyz.scm, those >> without ghc- prefix into haskell-apps.scm), as per >> https://lists.gnu.org/archive/html/guix-devel/2019-07/msg00070.html There=E2=80=99s a bit too much going on this commit. Would it be possible = to make the first commit do nothing but delete packages from =E2=80=9Chaskell.= scm=E2=80=9D and move them to the =E2=80=9Capps=E2=80=9D, =E2=80=9Ccheck=E2=80=9D, and = =E2=80=9Cxyz=E2=80=9D modules, and update the module references? Then, you can have another commit to move the SDL packages from =E2=80=9Capps=E2=80=9D to =E2=80=9Cxyz=E2=80=9D, and another = for the module commentaries. This way, it will be a lot easier to see what=E2=80=99s going on. Also, it looks like you=E2=80=99ve reordered some packages in =E2=80=9Chask= ell-xyz=E2=80=9D in this commit, too. I agree with Ricardo that it=E2=80=99s probably best to = leave the ordering alone, but if it needs to be done, it should be it=E2=80=99s o= wn commit. About the commit message, you don=E2=80=99t need to write each variable nam= e out twice. You can group all the files that have updated module references, too. See commit 0791437f972caa7e48de91ad5cb150a614f617c2 for Ricardo=E2=80= =99s message when moving the Guile packages into =E2=80=9Cguile-xyz=E2=80=9D. I= don=E2=80=99t think you need the =E2=80=9C[A]s discussed on guix-devel=E2=80=9D part, but if yo= u want to keep it, you should provide a link to the discussion. I know last time I made a lot of fixes myself, but I=E2=80=99m hoping this feedback is useful for getting a better feel for Guix=E2=80=99s conventions. Let me know if you feel differently. :) -- Tim