cuirass

cuirass

[Vincent Legoll]

Hello,

I just made a tour of the new cuirass, this is
much nicer than when I last visited (a long
time ago). Kudos !

I saw a few glitches (with firefox 78.8.0esr)

* The "Home" & "Guix logo" buttons bothlink back to the home page (duplicate).

* The search combobox help popup window
is not on top level, probably on all pages.
So other page elements are displayed over
it.

* Overdirve1 does not have infos (missing
zabbix)

I have collected a buch of ideas for additions.

Should I create bugs for those or just the
above list will suffice ?

Thanks a lot for the improvements !

PS: Sorry for ENOPATCH but I'm not good at
web.

-- 
Vincent Legoll

Re: cuirass

[Ricardo Wurmus]

Vincent Legoll <vincent.legoll@gmail.com> writes:

> * The search combobox help popup window
> is not on top level, probably on all pages.
> So other page elements are displayed over
> it.

I noticed that too.

The rule for “#search #search-hints” should have a “z-index: 1;” or
similar, so that the icons don’t overlap the search box.

-- 
Ricardo

Re: cuirass

[Vincent Legoll]

> The rule for “#search #search-hints” should have a “z-index: 1;” or
> similar, so that the icons don’t overlap the search box.

Like the following ?

diff --git a/src/static/css/cuirass.css b/src/static/css/cuirass.css
index e713b6f..2754415 100644
--- a/src/static/css/cuirass.css
+++ b/src/static/css/cuirass.css
@@ -4,6 +4,7 @@
 #search #search-hints {
     display: none;
     position: absolute;
+    z-index: 1;
     top: 3em;
     background: white;
     border: 1px solid #ced4da;

-- 
Vincent Legoll

Re: cuirass

[Mathieu Othacehe]

Hello,

> * The "Home" & "Guix logo" buttons bothlink back to the home page (duplicate).

Yes, but I'm not sure what to do about that. Maybe remove the logo link.

>
> * The search combobox help popup window
> is not on top level, probably on all pages.
> So other page elements are displayed over
> it.

I applied your patch, thanks!

> * Overdirve1 does not have infos (missing
> zabbix)

Yes, that's on purpose, the Overdrive resources are limited, and running
Zabbix and its PostgreSQL database wouldn't help.

> I have collected a buch of ideas for additions.
>
> Should I create bugs for those or just the
> above list will suffice ?

We can discuss them here I think. Don't hesitate if you have other
improvements ideas.

Thanks,

Mathieu