From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6Bt4FW+gFWPNlwAAbAwnHQ (envelope-from ) for ; Mon, 05 Sep 2022 09:08:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id mONLFW+gFWOcpwAA9RJhRA (envelope-from ) for ; Mon, 05 Sep 2022 09:08:31 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 124A6F561 for ; Mon, 5 Sep 2022 09:08:30 +0200 (CEST) Received: from localhost ([::1]:40344 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oV6Dd-0007WA-SS for larch@yhetil.org; Mon, 05 Sep 2022 03:08:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oV6Cq-0007UZ-EY for guix-devel@gnu.org; Mon, 05 Sep 2022 03:07:44 -0400 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]:52237) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oV6Cn-00013y-Kt; Mon, 05 Sep 2022 03:07:39 -0400 Received: (Authenticated sender: andrew@trop.in) by mail.gandi.net (Postfix) with ESMTPSA id E1D2AFF80C; Mon, 5 Sep 2022 07:07:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=gm1; t=1662361649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zh2zsMsojeMfoP2g3Cm9uDtzzXblosyULRgxQ2+w6k0=; b=SK+9Sdi8AYHEIoZog9tfTonKgLvwoB9FQ/QOGC5JYyt9zJGmBIplie4lCXF/BqzyqWad5x Tksj2t4zfq8b3Lq4VTDfNpUlIjxGWJEvkOUHnypzR5n9qT8m5GBpx9md5xZ2EyjNwlcaGq FHOkgZenn34+sVxQUjqUTanbigf6toRhMhRFd98wIE93Cq7lP4vUyB9HuxRPyg0B7s0wQJ PBBlERYuUYg4WUwMMDBUeoCMF05js1YGUswDouTaBQ9nnbmhSAqn8EcO3qy2xnE9a7QeS3 QsiXtUNqgqhfYEJHY8QBaEfS1t1L6EW/HikyemHvEFWlcKuXJsmf243OfOVOzA== From: Andrew Tropin To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org, Tobias Geerinckx-Rice , Efraim Flashner Subject: Re: [POSTMORTEM] Subkey is not authorized by .guix-authorizations In-Reply-To: <87ilm5x64a.fsf@gnu.org> References: <87tu6idfgd.fsf@trop.in> <87ilm5x64a.fsf@gnu.org> Date: Mon, 05 Sep 2022 10:07:25 +0300 Message-ID: <87czcaxpsi.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2001:4b98:dc4:8::229; envelope-from=andrew@trop.in; helo=relay9-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662361711; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Zh2zsMsojeMfoP2g3Cm9uDtzzXblosyULRgxQ2+w6k0=; b=FvqV4BnE0bEtHudfbLA7yT007J+/Nz4Z1rZgL1W8vIH2oJo8dppBZHwc9OFHLd8taj1/Qe +ZE8Mc+whMEOWCzwVbhiYLBxP/YMKWRv86i58wUbRQM2WLQELOxcUmd5+ajg+m+XyMWS93 X0QCo7Uz8RIQIM5jGHZFkAFRHE+oLtZI62GAiaeLsqWTDHLX4z5YYKdo4RuVceF8kk6vr1 AcmztwCIJZM34SW3Nf8c7CgXHAGwAn27O+JieAKlr56ixs6p+8CnfC5WFfIdD3zhK7dYIA +F8JEioNFT7wRBK4om1qsfTQlO4waq7Iwd0LdXIJv2BvLB7X5ZwZ05YxGf+hzg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662361711; a=rsa-sha256; cv=none; b=UJSxES8S+vy5dN5A2uPe4CPUJkveBB3ldSuhPnTPLdARZQFg0bu/hCpIflCGYJuYA4YNl9 me1SEga6bfLzj9pThUdaE5fAvr4jdXPWwh3Il765s4xuexh+xJWBCmxvkpIe8mBXBQNapj 4WjRMuHHdQo9rdlIIuOR6zE5HC+R/WGMYVyIZ38HLkiOVZF4pw5TTA4UffrSLrq3oAaHIe FV1ovmVynz1xLNpVZF7aZvoY+BS0hBx3NtajBVvmCSDLCFEuqwT0G3of6CE/RFC8OxX90m 104G45yS6G+Lftj8kMq/ExZlvKSKF4ZuVACVnoriJ7WtDUYz+1WYUjpnmSpUDQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=trop.in header.s=gm1 header.b=SK+9Sdi8; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.48 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=trop.in header.s=gm1 header.b=SK+9Sdi8; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 124A6F561 X-Spam-Score: -5.48 X-Migadu-Scanner: scn1.migadu.com X-TUID: XBKwUJ2sa6ht --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2022-09-02 15:23, Ludovic Court=C3=A8s wrote: > Hello! > > I=E2=80=99m late to the party, but thanks a lot for sending this analysis! > > Andrew Tropin skribis: > >> * What could be done better? >> - guix pull could be done from local checkout, before pushing. > > Setting a pre-push hook that invokes =E2=80=98guix git authenticate=E2=80= =99, as > recommended in the manual (info "(guix) Commit Access"), should be > enough: =E2=80=98git push=E2=80=99 would just fail in that situation. For some reason I thought it does git verify-commit, which I used manually to check if commit is signed, but it does make authenticate, which of course works the other way. Missed it, my bad. I have elaborated on this topic a little more in the manual. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-doc-Add-more-info-about-commits-signature-local-veri.patch Content-Transfer-Encoding: quoted-printable From=20e510ea1595c54bec788485f0638967d457afaf3d Mon Sep 17 00:00:00 2001 From: Andrew Tropin Date: Mon, 5 Sep 2022 09:46:23 +0300 Subject: [PATCH] doc: Add more info about commits signature local verification. * doc/contributing.texi (Commit Access): Add more info about commits signat= ure local verification. =2D-- doc/contributing.texi | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/doc/contributing.texi b/doc/contributing.texi index b1d236c011..17a54f94cc 100644 =2D-- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -1627,14 +1627,23 @@ git config commit.gpgsign true git config user.signingkey CABBA6EA1DC0FF33 @end example =20 =2DYou can prevent yourself from accidentally pushing unsigned commits to =2DSavannah by using the pre-push Git hook located at =2D@file{etc/git/pre-push}: +To check that commits are signed with correct key, use: + +@example +make authenticate +@end example + +You can prevent yourself from accidentally pushing unsigned or signed +with the wrong key commits to Savannah by using the pre-push Git hook +located at @file{etc/git/pre-push}: =20 @example cp etc/git/pre-push .git/hooks/pre-push @end example =20 +It additionally calls @code{make check-channel-news} to be sure +@file{news.scm} file is correct. + @subsection Commit Policy =20 If you get commit access, please make sure to follow =2D-=20 2.37.2 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable >> - Accept subkey on guix pull if master key is in .guix-authorizations. > > Reported at . > >> - Add pre-push hook, which checks authorization on Savannah. > > That one is difficult: Guix is not installed on those machines. > > Another option would be to push to a different machine, one that we > control, and make Savannah a mirror of that one. It can work, but looks fragile. > > Thoughts? Let's ask savannah admins if it possible to install guix on those machines and add pre-receive/update hook? If not, we will look for other options. =2D-=20 Best regards, Andrew Tropin --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmMVoC0ACgkQIgjSCVjB 3rBXMg//UWwHmmgh8lqeYFm3nIK4SBvFvcrO+Wah5clADpWJXCDmAS/I239TKhl1 kRXV2yLKGBcm9Fd5RHZdTiqFrFgJKzBrfLwGAeGIJPRV6KOAqkAFe1pg07pJtta4 d7zhpJzexUf/2sG7BGclME1SQZZNRUwL58DacMrZNK5Q1ZOiPLaRMQEyRx4uu7XK mmcgDRAtAsaHmux+ASAZdgrxvNWKusRhpuTz/Y7FxqwLNy27u5wgC7l7I3itOfGT LJDr0sNoIjDjIzgJH/wyw6HWxDfUetHcEdl030l3asgEQrPY+bDhgNhprmjw4xPj gqU49+DfeSgqpJ1IBDBEISH9TB3SzAsSPiCyYjoxiFUVlJOZaLMr4moEBNnlmAGv 5Dcwx8GrG12ErkaQB1xFgBs6rCXuDh0hW47EdN9GvLV837VeU3BxH1gLDtzMH35o 5Bo9m+tOittvDRVwk/jAnFN+28jHYlsMvJbz0bwOIJlMTREq7fIM63n7MVKQAivI VakcoxjmS4PpBF3O4lInqjqvQs6OD3udgv2g5Ap4cKDmrYrGZkrhdKnTJBB5liDn dnqTHcrpBE5IwVxqYP/Ion9o2RRppMIS3kQ/RuhC7cifSHHuJbW0o1cBOWbczFxE QdxY0jK0nuDtFvqK/FMaNu+alu4nf1nmvLWog3XLVdDdhDC3WXk= =9Llj -----END PGP SIGNATURE----- --==-=-=--