From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yFiSM7vAPWM+FQEAbAwnHQ (envelope-from ) for ; Wed, 05 Oct 2022 19:36:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KEmSM7vAPWMqXwAAauVa8A (envelope-from ) for ; Wed, 05 Oct 2022 19:36:59 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 985E17587 for ; Wed, 5 Oct 2022 19:36:59 +0200 (CEST) Received: from localhost ([::1]:44324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1og8KI-0003Xk-QH for larch@yhetil.org; Wed, 05 Oct 2022 13:36:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1og7tP-0007kx-6z for guix-devel@gnu.org; Wed, 05 Oct 2022 13:09:11 -0400 Received: from mira.cbaines.net ([212.71.252.8]:36748) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1og7tM-0006Jv-Ta for guix-devel@gnu.org; Wed, 05 Oct 2022 13:09:10 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:3a91:a0a4:ecee:f157]) by mira.cbaines.net (Postfix) with ESMTPSA id A134127BBE9; Wed, 5 Oct 2022 18:09:07 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 4a9a4f41; Wed, 5 Oct 2022 17:09:07 +0000 (UTC) References: <87a66wfzeh.fsf@cbaines.net> <166497850086.2821.11724664487538606446@localhost> User-agent: mu4e 1.8.9; emacs 28.1 From: Christopher Baines To: Tanguy LE CARROUR Cc: guix-devel@gnu.org Subject: Re: Notes from discussion on Quality Assurance from the 10 Years of Guix event Date: Wed, 05 Oct 2022 17:51:52 +0100 In-reply-to: <166497850086.2821.11724664487538606446@localhost> Message-ID: <87czb642q7.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664991419; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=ov6h3TkZPnLuIeawCy0dLSFv3mtRsayWU1M4pwJ0pJg=; b=oo5y3lTpXeVLKWuI9fL8aunhTJB9cL1AaafwlnoNBQTCtL6kQHBWaJ1mzqBAxUx1mYKD9M Ab33b15PxpeAiB+DXZbqmqU26wMEtckH3Fm1bQA7PACwsjNVOD8hDQTVoe/NW8ApCeunBY lq776tYWyPZHzyT7/ekcSLaRMKJ2GE0zSjQSJKxc26BIYupnFjWvW7zDSNqyFf90/iTub+ QAQ6tyWzl026fmoeaAaU2QUED5xcc//wrKybNruyHvtCxuOPy1vAHCO47lbn/8SGUFBmgk SO6pD5St5MzUs33NBg2LBjAmnzBvNH5edrCXBEKbzr0vzKFTBx2tb5cccuTBnQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664991419; a=rsa-sha256; cv=none; b=QVnITVAyMsyRgtXUR9kY3pqwGsHy4smb9asDyzI3xnXJ1b8vkkOkfChu2ozwURZ0ni6+Eo pbRIODWFxsgWaHsv17ZeuQH6heGkTYeocW2MQUKK2UuXthga50otZvPHUzZSaFV9k0iK0T o7FsT3FNHnr9Dzr9V3evY8qOH9dH/qpvFKY0BozcEp8j73MvaMGE72hILqLu+eB0yY1VXe FpaH4MVLuz0RPz5Fq6JrB9TnFz9MDrG1j10TDLyAz1kA/xk/N6yvizGEKIcQvrY1c//o3r JE5oTD5WrT5TjODrx4Um//HG4ZE4SIQ6ad289tylMlyefvsGWc4CaSkwWO7CtQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.76 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 985E17587 X-Spam-Score: -5.76 X-Migadu-Scanner: scn0.migadu.com X-TUID: NiDu2lvnZImq --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tanguy LE CARROUR writes: >> - Minimise the burden for submitters >> - Lengthy guidance for submitting patches > > Actually, the `16.4 Packaging Guidelines` and `16.6 Submitting Patches` > are everything that I've ever looked for. I think the point here is that the Submitting Patches section is quite long. > The only problem is `16.5.4 Formatting Code` that makes use of `./etc/ind= ent-code.el` > that was removed back in January. The latest version of the manual suggests using guix style, so this is maybe a problem limited to old versions of the manual? >> - Changelog format > > "format" and "content". > > I've heard about a magic trick in Emacs, but as a user of "the other edit= or", > I have to write everything manually. > > I guess one could write a command that would detect what has changed and > write the changelog. This could also be used on the reviewer/qa side to > check if the patch actually does what it says it does. I think there's room for improvement here in terms of telling people not to worry about it too much, plus providing more guidance on the format and common examples. There's also tooling like the etc/committer.scm script which I don't know anything about really, but it seems to handle writing this message in some cases. >> - Sending patches by email (git send-email) > > This one is an easy one!=E2=80=A6 at least, as long a you only have 1 pat= ch. > For a patch set, one has to generate a cover letter, send it, wait for > a bug id to be assigned then send the rest of the patch set. > Looks trivial, but (too) many times I ended up creating multiple bug > reports for the same patch set. And the fear of messing up the bug report= system > was something that discouraged me at the beginning. I still do some > mistake from time to time, but=E2=80=A6 I do not care any more, because I= now > know how to fix them. Indeed, this is still an issue. >> - Delay in feedback for first time submitters > > It doesn't actually have to be a human feedback. But being able to know > that everything went well (or not) and what's the status of a patch is > would be great. Yep, and I think we are getting close to being able to do that. >> - Learn how to review more patches > > Also learn how to review your first patch! Being able to push a "+1" > button in the QA interface might be useful? > For the time being, I don't know what feedback from me could be useful > for a commiter and how to provide it. Yep, I think Arun had some useful ideas on this back in February [1]. Particuarly including a checklist somewhere (issues.guix.gnu.org or maybe qa.guix.gnu.org). 1: https://guix.gnu.org/en/blog/2022/online-guix-days-2022-announcement-2/ >> Actions: >> - teams thing for finding out about patches, automate this somehow >> - generate a web page listing the people and teams >> - Filtered subscription to patches by team > > What the status on this? Where can I learn more about how teams work? There's been a few messages to guix-devel. It's not something I know much about either. From=20my perspective, I'd like to be able to use this information in the qa-frontpage. I think the path to make that happen involves moving the work currently done through Laminar to create the branches for patch series in to the qa-frontpage, as that should make it easy to access the files changed in a patch series. >> - Maybe script making contributions like updating packages >> - Make a similar tool to Debian's how can I help >> - Try to avoid suggesting updating packages with lots of dependencies > > `guix how-can-i-help` would be amazing! Something that would: > - list all the packages in my current profile that can be updated, > sorted by number of dependent packages; and > - list all the packages in my profile that are currently broken. Indeed :) > Actually, for the second point, I guess I'll figure out when upgrading > my profile. Or maybe `guix weather` can help!? > > I guess I'll have to dive more into QA, Data Service, Weather to be of > any help. But if you see anything that requires zero-knowledge just let > me know! =F0=9F=98=81 Please let me know if I can help with any of this. The QA frontpage in particular should have a bunch of easier things to do, and I've got a rough list of tasks I put together here [2]. 2: https://git.cbaines.net/guix/qa-frontpage/about/ Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmM9ujBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xda5A/+Kvkll0h31DNJi2H8trQYhXDLwewnO9oW V9YRJyJWDMNHXEFGNfHZuW09b2YUCywZx0yPeeAx7uN1eDewvKnZvgb/oFxABWzm DfliMDgdOx0paZ+AOOG1lnl9yozCnIZ/ERkQyJg0zmBrT2ayg8D4I8zAPX82uvwd q+GdyzWhQCzcqAt1jZAiEjd/i7te/wVMYqO6fGakfU3PPpoW5YODCnhqk0LrGq7o WC9sroPbKiSUXVVtw/FOG/ysCdmP+qG1vn2m0dOYgGrRqOAH3lbCq9FS6Gsw5jw0 SLCXgyy23ViTiTUXGiqOi1FyODFif4i7MYVGlp8FRS/Da9XCxjNT6y7vnf26GbEn KEKkElPYLAiOMIRWMQKxrU9T2wUYxbwLH9N0J0DvJ0ic+oDgY3UL9azYkXBGJ1Tx Vd8hJ1RK+EQ1b4l8+zy8H2VYUXmhbOgXOfKvwf8R6VtLQeHMpEturG1/cFTjM0yD aitySKxWkkuFQha5R12zcmiMAXvjWTfz62gW1/dm3B79at8U160RGn0xUFKY90sp rz9DruOmqnlOSLgcdikeNIcUj3qg3FYN6UlM694yeOvWXqv8gvQOgco7f+vblc7P GkVzqxNcMYlo5Qj8XPijBtdYCEUkfSqgUAbkjXSoBwsCBhalxLcIkAFjzb6ZZUfm LQB6dlc/ZIQ= =VWkU -----END PGP SIGNATURE----- --=-=-=--