From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id oMxwMZ/vSGUFHAAAG6o9tA:P1 (envelope-from ) for ; Mon, 06 Nov 2023 14:52:32 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id oMxwMZ/vSGUFHAAAG6o9tA (envelope-from ) for ; Mon, 06 Nov 2023 14:52:31 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B38D616A57 for ; Mon, 6 Nov 2023 14:52:31 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lassieur.org header.s=fm2 header.b="ToVLsBW/"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=I3G7Bxf4; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1699278751; a=rsa-sha256; cv=none; b=gE++AaeNYmBDzvLvomc1l5wC7O8xYG2bBZZaC1/c4nmFmZdyWAZDge+4OLDTR3LBm8qLWK J+K6iZj+iTaxtYFTLMSdZveIrxfay3d8qhAdF9pJU8v3gIQIxl8XZdm9umefrw/ODFIxV7 IHT7DBhvFW+isU6EW2jFoETb9jOSfqsZniiOaEcHYoMeYVYV8+hWUmWqnG0u9IMWGgX191 N6nOjT9pkaDos1j7dO4qNFj1Xdqe5LnLzRnRs0Jxs7GdlDFznmusn8H4JGtAWhsPBu4/0T Hn2hc+F1DUGaeH2WcqU41pOtisIVVolEs877MbBKBTOQTCsqUXgPBip4uR7TuQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lassieur.org header.s=fm2 header.b="ToVLsBW/"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=I3G7Bxf4; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1699278751; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Z7zabKS7kXAUvW4qI+fDY+v/WID/p/nak/bGnbadXPM=; b=CFkV2kxCuLLFxK4FKSHBWW9zaRrxFpuf1/PgtltCINK/OrfOJeErV6EC7RSOIr+zJ2JavQ ZiEclrGOvhCc7NZWZ9Htd3ZeY9p/2mPU3Ac1pdhDAL1N42uAMNHkUEhSyjIGxA3xqksgvD RcMYtwcZxvJOKpQo9K6gfLS9injuQdj0CmAAI4Jr6fbQ/gE8y5K3QQevLOtJIkQHuFJ7MX wF1hKg5CkeKRWcEeo1LhAjZPSgwNcCcrLCaJjN3bgol2IlvoEqn2m4tpykL1pfH+BgyP+B Bw2jbLPVP3c48jP2AJysk+uktpnFFNWGRx2/nXU7Igi/SjUwI8ZIVFZWWafgPw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0017-0006QJ-SO; Mon, 06 Nov 2023 08:51:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0016-0006Q8-Tb for guix-devel@gnu.org; Mon, 06 Nov 2023 08:51:48 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r000t-00070T-So for guix-devel@gnu.org; Mon, 06 Nov 2023 08:51:48 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 13DAF5C0065; Mon, 6 Nov 2023 08:51:35 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 06 Nov 2023 08:51:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1699278695; x=1699365095; bh=Z7 zabKS7kXAUvW4qI+fDY+v/WID/p/nak/bGnbadXPM=; b=ToVLsBW/AmHCrCoNQ9 5Bq5tJhyyVFU7jNdVtdWOL0xirDfz8S4A7TFZydCejmyi8JymkFJc9Mk8IMgaUlL bpUKzcph19RAAHslnZmz2xwxSPi905vkHwnzP466/3sAVD0xjbQ8R5hwR1MGVU97 OH4WMByhA+7BVJo8hhO1Ci6yPXZ+8IICjd/gHeG1w1aqNbc1sxKd1NwAJVEjki4n zLcgaTD4+HItTT3+avCwepYko/hDfWkexLQFZtcYQeMzdduz9iZhksLPyh8g9cRc uTye1wA0gbXCH2GgUGxcUrlSfJ/Z4fEwR9jWaYpYTVxxIoyaqxdexY9tPSckmhYG AOqg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1699278695; x=1699365095; bh=Z7zabKS7kXAUv W4qI+fDY+v/WID/p/nak/bGnbadXPM=; b=I3G7Bxf4F+mxTPBFouivPGYg0IQqk 8joBBYFMukcRLcVUfm6UzBfBLvx7fURl543Vw56ElOmkU2yGVhhDhUHqiZpvbtpg gvrWm8iCoErlTdylJly49857jnR/SwQqBuMDNl+TYJr9hMEaKzkSoGkhQY8VZbry 6NYYXOIL2uOfwSFav4eprE63YMmV06PboBTvkJ2fS0N26vZgXFIGM2UlqJRr5BPR 39K7dHbx+dR8+gqzUcq2O9SVh7nufTnfwK19U+N3svWWeQ7L/HjxqhV1aqD8zsBT R7qa5vAJ1QXiL3+PDGcDHUV93A0JkQMfeJks3kBUgNkH4qE9MUv1hHL4w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddugedgheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufgjfhffkfgfgggtsehttd ertddtreejnecuhfhrohhmpeevlhormhgvnhhtucfnrghsshhivghurhcuoegtlhgvmhgv nhhtsehlrghsshhivghurhdrohhrgheqnecuggftrfgrthhtvghrnhepvdeitdevleejfe fgfeeuveetgeetudfhtdegudffteeiheegkeetveejhfeujeejnecuffhomhgrihhnpegt sggrihhnvghsrdhnvghtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomheptghlvghmvghntheslhgrshhsihgvuhhrrdhorhhg X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Nov 2023 08:51:33 -0500 (EST) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= To: Christopher Baines Cc: jgart , guix-devel@gnu.org Subject: Re: Patch Review Flow In-Reply-To: <87v8afiagf.fsf@cbaines.net> (Christopher Baines's message of "Mon, 06 Nov 2023 07:51:58 +0000") References: <87v8afiagf.fsf@cbaines.net> Date: Mon, 06 Nov 2023 14:51:31 +0100 Message-ID: <87cywn0z30.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=66.111.4.26; envelope-from=clement@lassieur.org; helo=out2-smtp.messagingengine.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: B38D616A57 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -5.21 X-Spam-Score: -5.21 X-TUID: LNNkWuteSxsC On Mon, Nov 06 2023, Christopher Baines wrote: > "jgart" writes: > >> Does anyone follow this workflow for reviewing patches? >> >> git clone https://git.guix-patches.cbaines.net/guix-patches/ >> git checkout issue-xxxxx >> git format-patch ... >> # then in the development checkout of Guix: >> git am ...; make; ./pre-inst-env guix build >> >> Should we document it in the manual? >> >> Does anyone follow a workflow that is more efficient than the above? > > I have the guix-patches repository as a remote, which I then cherry pick > from (via Magit), which makes it quick and easy to apply patches. Or with Emacs you can apply patches directly from the Gnus or the Debbugs interface.