From: ludo@gnu.org (Ludovic Courtès)
To: John Darrington <john@darrington.wattle.id.au>
Cc: guix-devel@gnu.org, John Darrington <jmd@gnu.org>
Subject: Re: [PATCH] gnu: gnome-doc-utils: Do not omit tests
Date: Mon, 23 Jun 2014 10:12:31 +0200 [thread overview]
Message-ID: <87bntknixc.fsf@gnu.org> (raw)
In-Reply-To: <20140623044444.GA19164@jocasta.intra> (John Darrington's message of "Mon, 23 Jun 2014 06:44:45 +0200")
John Darrington <john@darrington.wattle.id.au> skribis:
> On Sun, Jun 22, 2014 at 09:40:32PM +0200, Ludovic Court??s wrote:
>
> John Darrington <jmd@gnu.org> skribis:
>
> > * gnu/packages/gnome.scm (gnome-doc-utils): Added pre-check phase and do not
> > skip check phase
>
> [...]
>
> > + ;; This stuff is needed, because without it, xmlint etc tries
> > + ;; to download docbookx.dtd and docbook.xsl from the net
> > + (let ((build (assoc-ref %standard-phases 'build))
> > + (docbook-xml (assoc-ref inputs "docbook-xml"))
> > + (docbook-xsl (assoc-ref inputs "docbook-xsl"))
> > + (our-catalog "/tmp/docbook-xml.xml"))
> > + (setenv "XML_CATALOG_FILES" our-catalog)
> > + (with-output-to-file our-catalog
> > + (lambda ()
> > + (display (string-append
> > + "<?xml version=\"1.0\"?>
> > +<!DOCTYPE catalog PUBLIC \"-//OASIS//DTD XML Catalogs V1.0//EN\"
> > +\"file:///usr/share/xml/schema/xml-core/catalog.dtd\">
> > +<catalog xmlns=\"urn:oasis:names:tc:entity:xmlns:xml:catalog\">
> > +<system systemId=\"http://www.oasis-open.org/docbook/xml/4.4/docbookx.dtd\"
> > +uri=\"file://" docbook-xml "/xml/dtd/docbook/docbookx.dtd\"/>
> > +<system systemId=\"http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl\"
> > +uri=\"file://" docbook-xsl "/xml/xsl/docbook-xsl-1.72.0/manpages/docbook.xsl\"/>
> > +</catalog>\n"))))))
> > + %standard-phases)))
>
> Seems about time to discuss factorization. :-)
>
> Docbook-{XML,XSL} both provide a catalog.xml file. Would it be enough
> to set XML_CATALOG_FILES=/first/one/catalog.xml:/second/one/catalog.xml
> rather than creating a new catalog.xml file that just points to them?
>
> The problem is, that some files refer to
>
> http://www.oasis-open.org/docbook/xml/4.4/docbookx.dtd
> others to
> http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd
> or
> http://www.oasis-open.org/docbook/xml/4.2.1/docbookx.dtd
>
> Similarly, I have seen urls like
> http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
> http://docbook.sourceforge.net/release/xsl/1.72/manpages/docbook.xsl
> and other variations.
This seems to be a matter of providing packages for all these versions,
no?
I suppose the catalog.xml file in the ‘docbook-xml-4.4’ package does the
right thing for the 4.4 URLs, doesn’t it?
Ludo’.
next prev parent reply other threads:[~2014-06-23 8:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-22 7:30 [PATCH] gnu: gnome-doc-utils: Do not omit tests John Darrington
2014-06-22 19:40 ` Ludovic Courtès
2014-06-23 4:44 ` John Darrington
2014-06-23 8:12 ` Ludovic Courtès [this message]
2014-06-23 9:02 ` John Darrington
2014-06-23 12:22 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bntknixc.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=jmd@gnu.org \
--cc=john@darrington.wattle.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).