From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 20/31] gnu: Add python-discover.
Date: Fri, 05 Sep 2014 22:10:50 +0200
Message-ID: <87bnqtx1yt.fsf@gnu.org>
References: <1409930317-13220-1-git-send-email-dthompson2@worcester.edu>
	<1409930317-13220-20-git-send-email-dthompson2@worcester.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34766)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XPzqS-0000wL-BM
	for guix-devel@gnu.org; Fri, 05 Sep 2014 16:11:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XPzqO-00042h-3s
	for guix-devel@gnu.org; Fri, 05 Sep 2014 16:10:56 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:60099)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XPzqN-00042d-U4
	for guix-devel@gnu.org; Fri, 05 Sep 2014 16:10:52 -0400
In-Reply-To: <1409930317-13220-20-git-send-email-dthompson2@worcester.edu>
	(David Thompson's message of "Fri, 5 Sep 2014 11:18:26 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

David Thompson <dthompson2@worcester.edu> skribis:

> * gnu/packages/python.scm (python-discover, python2-discover): New variab=
les.

[...]

> +(define-public python-coverage
> +  (package
> +    (name "python-coverage")
> +    (version "3.7.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://pypi.python.org/packages/source/c/coverage/coverag=
e-"
> +             version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0knlbq79g2ww6xzsyknj9rirrgrgc983dpa2d9nkdf31mb2a3bni"))))
> +    (build-system python-build-system)
> +    (inputs
> +     `(("python-setuptools" ,python-setuptools)))
> +    (home-page "http://nedbatchelder.com/code/coverage")
> +    (synopsis "Code coverage measurement for Python")
> +    (description
> +     "Coverage measures code coverage, typically during test execution. =
 It
> +uses the code analysis tools and tracing hooks provided in the Python st=
andard
> +library to determine which lines are executable, and which have been
> +executed.")
> +    (license bsd-3)))
> +
> +(define-public python2-coverage
> +  (package-with-python2 python-coverage))

This one looks OK, but you may want to move it to a separate patch, or
to mention it in the commit log.

> +(define-public python-discover

OK.

Ludo=E2=80=99.