unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 4/5] guix lint: Make sure a synopsis cannot start with a lower-case article.
Date: Sun, 28 Sep 2014 18:11:14 +0200	[thread overview]
Message-ID: <87bnpzafod.fsf@gnu.org> (raw)
In-Reply-To: <1411854568-11187-5-git-send-email-tipecaml@gmail.com> (Cyril Roelandt's message of "Sat, 27 Sep 2014 23:49:27 +0200")

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * guix/scripts/lint.scm (check-start-article): use "string-ci=?" instead of "string=?".
> * tests/lint.scm: Add corresponding tests.

Test names, lines wrapped please.  :-)

>    (define (check-start-article synopsis)
> -   (if (or (string=? (string-take synopsis 2) "A ")
> -           (string=? (string-take synopsis 3) "An "))
> +   (if (or (string-ci=? (string-take synopsis 2) "A ")
> +           (string-ci=? (string-take synopsis 3) "An "))

There’s also a problem if SYNOPSIS is shorter, but I wonder if we should
worry about it?

Ludo’.

  reply	other threads:[~2014-09-28 16:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-27 21:49 [PATCH 0/5] Add, fix and improve checkers in guix lint Cyril Roelandt
2014-09-27 21:49 ` [PATCH 1/5] guix lint: make sure check-patches retrieves patch names Cyril Roelandt
2014-09-28 10:08   ` Ludovic Courtès
2014-10-06  0:26     ` [PATCHv2 " Cyril Roelandt
2014-10-06 15:57       ` Ludovic Courtès
2014-09-27 21:49 ` [PATCH 2/5] guix lint: Make sure synopses are not too long Cyril Roelandt
2014-09-28 10:09   ` Ludovic Courtès
2014-09-27 21:49 ` [PATCH 3/5] guix lint: check whether descriptions and synopses start with an upper-case letter Cyril Roelandt
2014-09-28 16:09   ` Ludovic Courtès
2014-10-06  0:27     ` [PATCHv2 " Cyril Roelandt
2014-10-06 16:00       ` Ludovic Courtès
2014-10-06  0:28     ` [PATCH " Cyril Roelandt
2014-10-06 15:58       ` Ludovic Courtès
2014-09-27 21:49 ` [PATCH 4/5] guix lint: Make sure a synopsis cannot start with a lower-case article Cyril Roelandt
2014-09-28 16:11   ` Ludovic Courtès [this message]
2014-10-06  0:28     ` Cyril Roelandt
2014-09-27 21:49 ` [PATCH 5/5] guix lint: make sure synopses do not start with the package name Cyril Roelandt
2014-09-28 16:11   ` Ludovic Courtès
2014-09-28 16:49 ` [PATCH 0/5] Add, fix and improve checkers in guix lint Andreas Enge
2014-10-04 14:25   ` Cyril Roelandt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bnpzafod.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=tipecaml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).