From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add bowtie.
Date: Wed, 17 Dec 2014 21:41:52 +0100 [thread overview]
Message-ID: <87bnn2huun.fsf@gnu.org> (raw)
In-Reply-To: <idjwq5r5xr6.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Tue, 16 Dec 2014 18:07:41 +0100")
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
> From 713bb1145ff901c4069f2fadb210d8eb842981da Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 16 Dec 2014 17:52:44 +0100
> Subject: [PATCH] gnu: Add bowtie
>
> * gnu/packages/bioinformatics.scm (bowtie): New variable.
[...]
> + 'patch-makefile
> + (lambda _
> + (substitute* "Makefile"
> + (("^CC = .*$") (string-append "CC = " (which "gcc")))
> + (("^CPP = .*$") (string-append "CPP = " (which "g++")))
> + ;; replace BUILD_HOST and BUILD_TIME for deterministic build
> + (("-DBUILD_HOST=.*") "-DBUILD_HOST=\"\\\"guix\\\"\"")
> + (("-DBUILD_TIME=.*") "-DBUILD_TIME=\"\\\"0\\\"\"")))
Could you make this a ‘snippet’? It suffices to write “CC = gcc” and
“CPP = g++”. That way, running ‘guix build -S bowtie’ will return
source that’s closer to what we’re using.
> + (license license:gpl3)))
From a quick glance, this should be ‘gpl3+’ (source file headers carry
the “or any later version” phrase.)
Could you post an updated patch?
TIA,
Ludo’.
next prev parent reply other threads:[~2014-12-17 20:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 17:07 [PATCH] gnu: Add bowtie Ricardo Wurmus
2014-12-17 20:41 ` Ludovic Courtès [this message]
2014-12-18 16:15 ` Ricardo Wurmus
2014-12-19 17:52 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnn2huun.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).