From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] Add IBus.
Date: Thu, 26 Mar 2015 09:09:08 +0100
Message-ID: <87bnjgqixn.fsf@mango.localdomain>
References: <8761a1bejx.fsf@mango.localdomain> <87y4mwov05.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60021)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1Yb2qv-0002I0-Mh
	for guix-devel@gnu.org; Thu, 26 Mar 2015 04:09:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1Yb2qr-0006CP-Bl
	for guix-devel@gnu.org; Thu, 26 Mar 2015 04:09:21 -0400
In-Reply-To: <87y4mwov05.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>


Ludovic Court=C3=A8s writes:
>
>> +        (lambda* (#:key inputs outputs #:allow-other-keys)
>> +          ;; Make sure 'ibus-setup' runs with the correct PYTHONPATH =
and
>> +          ;; GI_TYPELIB_PATH.
>> +          (let ((out (assoc-ref outputs "out")))
>> +            (substitute* (string-append out "/bin/.ibus-setup-real")
>> +              (("exec ")
>> +               (string-append "export PYTHONPATH=3D\""
>> +                              (getenv "PYTHONPATH")
>> +                              "${PYTHONPATH:+:}$PYTHONPATH" "\"\n"
>> +                              "export GI_TYPELIB_PATH=3D\""
>> +                              (getenv "GI_TYPELIB_PATH")
>> +                              ":" out "/lib/girepository-1.0"
>> +                              "${GI_TYPELIB_PATH:+:}$GI_TYPELIB_PATH"
>> +                              "\"\n"
>> +                              "\nexec ")))
>
> I think it=E2=80=99s fine to use =E2=80=98wrap-program=E2=80=99 here, e=
ven if that means that
> there=E2=80=99s an additional wrapper layer.
>
> Unless there are performance concerns or similar, I think we should
> favor readability and maintainability.

I just pushed the commit after performing all suggested changes.
Thanks for the review!

~~ Ricardo