Re: [PATCH 3/3] gnu: Add MariaDB.

[ludo@gnu.org (Ludovic Courtès)]

宋文武 <iyzsong@gmail.com> skribis:

> * gnu/packages/database.scm (mariadb): New variable.

+s: “databases.scm”

> +        'configure 'pre-configure
> +        (lambda _
> +          (setenv "CONFIG_SHELL" (which "sh"))
> +          ;; XXX: libstdc++.so lacks RUNPATH for libgcc_s.so.
> +          (setenv "LDFLAGS" "-lgcc_s")

Indeed, but this is normally compensated by the fact that our GCC
automatically passed -Wl,-rpath=$gcclibdir, no?  What error where you
getting without it?

> +             ;; Install testing data to the 'test' output.
> +             (mkdir-p test)
> +             (system* "mv" (string-append out "/data")       test)
> +             (system* "mv" (string-append out "/mysql-test") test)
> +             (system* "mv" (string-append out "/sql-bench")  test)))

Could you use ‘rename-file’?

Otherwise LGTM.

Thanks,
Ludo’.