From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] gnu: Add tvtime. Date: Wed, 29 Apr 2015 12:31:49 +0300 Message-ID: <87bni7e0vu.fsf@gmail.com> References: <87pp6oc8hg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnOLY-0000PL-0y for guix-devel@gnu.org; Wed, 29 Apr 2015 05:32:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnOLT-0002rd-T7 for guix-devel@gnu.org; Wed, 29 Apr 2015 05:31:59 -0400 Received: from mail-lb0-x22f.google.com ([2a00:1450:4010:c04::22f]:34789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnOLT-0002rT-Ka for guix-devel@gnu.org; Wed, 29 Apr 2015 05:31:55 -0400 Received: by lbcga7 with SMTP id ga7so15708982lbc.1 for ; Wed, 29 Apr 2015 02:31:54 -0700 (PDT) In-Reply-To: (Eric Bavier's message of "Tue, 28 Apr 2015 17:14:37 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Eric Bavier Cc: guix-devel@gnu.org Eric Bavier (2015-04-29 01:14 +0300) wrote: > On 2015-04-28 15:18, Alex Kost wrote: >> From dcc331e7ab3fd0687c5a4ef8f084bc0bf4ca1cef Mon Sep 17 00:00:00 2001 >> From: Alex Kost >> Date: Tue, 28 Apr 2015 22:21:37 +0300 >> Subject: [PATCH] gnu: Add tvtime. >> >> * gnu/packages/tvtime.scm, >> gnu/packages/patches/tvtime-gcc41.patch, >> gnu/packages/patches/tvtime-pngoutput.patch, >> gnu/packages/patches/tvtime-videodev2.patch, >> gnu/packages/patches/tvtime-xmltv.patch: New files. >> * gnu-system.am (GNU_SYSTEM_MODULES): Add package. >> (dist_patch_DATA): Add patches. > > Perhaps we could name the file "tv.scm", in anticipation of other > TV-related code? Indeed, I think it would be better, thanks! >> + (inputs >> + `(("libx11" ,libx11) >> + ("libxt" ,libxt) >> + ("libxtst" ,libxtst) >> + ("libxinerama" ,libxinerama) >> + ("libxv" ,libxv) >> + ("libxxf86vm" ,libxxf86vm) >> + ("libpng" ,libpng) >> + ("libxml2" ,libxml2) >> + ("freetype" ,freetype) >> + ("zlib" ,zlib))) > > I think we were lately trying to stay away from aligning inputs like > this (ISTR Ludo requesting it not be done on some other patch reviews). > Not sure where the consensus is yet. OK, I'm going to remove the aligning. >> + (synopsis "High quality television application") > > How about "Television viewer"? I don't mind. Synopsis/description is always the hardest part for me :-) > Otherwise the rest look good to me. Thanks for reviewing. -- Alex