From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: base: Add glibc-hurd and hurd-minimal.
Date: Mon, 04 May 2015 17:11:16 +0200
Message-ID: <87bni0s7hn.fsf@gnu.org>
References: <CAFtzXzNFfHodFO=dVKVKG_ZKwEVdZgDu+S4Yj9DA=JkdnhCzTw@mail.gmail.com>
	<87a8xobaxf.fsf@gnu.org>
	<CAFtzXzPOaVFa-M=fxqAfB_GQRfe+AZb3Lt7yVLKT6o-QpNxsOQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50984)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YpI1k-0005G1-J5
	for Guix-devel@gnu.org; Mon, 04 May 2015 11:11:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YpI1e-0002pS-UZ
	for Guix-devel@gnu.org; Mon, 04 May 2015 11:11:24 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45016)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YpI1e-0002pO-SE
	for Guix-devel@gnu.org; Mon, 04 May 2015 11:11:18 -0400
In-Reply-To: <CAFtzXzPOaVFa-M=fxqAfB_GQRfe+AZb3Lt7yVLKT6o-QpNxsOQ@mail.gmail.com>
	(Manolis Ragkousis's message of "Sat, 2 May 2015 16:08:36 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel <Guix-devel@gnu.org>

Manolis Ragkousis <manolis837@gmail.com> skribis:

> From c64bb1c8c91b8f50d2955f5ae3bd1c8735ff40d9 Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Sat, 27 Sep 2014 20:07:19 +0300
> Subject: [PATCH] gnu: base: Add glibc-hurd and hurd-minimal.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=3DUTF-8
> Content-Transfer-Encoding: 8bit
>
> * gnu/packages/base.scm (glibc/hurd, glibc/hurd-headers): New variables.
> * gnu/packages/hurd.scm (hurd-minimal): New variable.
> * gnu/packages/patches/glibc-hurd-extern-inline.patch: New file.
> * gnu/packages/patches/libpthread-glibc-preparation.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add them.
>
> Co-authored-by: Ludovic Court=C3=A8s <ludo@gnu.org>
> Co-authored-by: Mark H Weaver <mhw@netris.org>

[...]

> +                           "ac_cv_search_clnt_create=3Dno")

Could you add the rationale as a comment just above (=E2=80=9CSkip the
clnt_create check because ...=E2=80=9D)?

> +     "This package provides libihash, needed to build the GNU C=20
> +Library for GNU/Hurd")

Missing period.

OK to commit to wip-hurd with these changes, thank you!

Ludo=E2=80=99.