From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH] gnu: Add rhythmbox.
Date: Thu, 18 Jun 2015 15:45:55 +0200
Message-ID: <87bngdi0z0.fsf@elephly.net>
References: <1434604057-17996-1-git-send-email-david.hashe@dhashe.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54447)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1Z5a8r-0001CH-SN
	for guix-devel@gnu.org; Thu, 18 Jun 2015 09:46:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1Z5a8m-0002xc-Tq
	for guix-devel@gnu.org; Thu, 18 Jun 2015 09:46:05 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:25474)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1Z5a8m-0002xC-Kg
	for guix-devel@gnu.org; Thu, 18 Jun 2015 09:46:00 -0400
In-reply-to: <1434604057-17996-1-git-send-email-david.hashe@dhashe.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Hashe <david.hashe@dhashe.com>
Cc: guix-devel@gnu.org


David Hashe <david.hashe@dhashe.com> writes:

> * gnu/packages/gnome.scm (rhythmbox): New variable.

[...]

> +(define-public rhythmbox
> + (package
> +   (name "rhythmbox")
> +   (version "3.2.1")
> +   (source (origin
> +            (method url-fetch)
> +            (uri (string-append "mirror://gnome/sources/rhythmbox/3.2/"

Can you use (version-major+minor version) instead of =E2=80=9C3.2=E2=80=9D =
here?

> +                                "rhythmbox-" version ".tar.xz"))
> +            (sha256
> +             (base32
> +              "0f3radhlji7rxl760yl2vm49fvfslympxrpm8497acbmbd7wlhxz"))))
> +   (build-system glib-or-gtk-build-system)
> +  (native-inputs
> +    `(("intltool" ,intltool)
> +      ("glib" ,glib "bin")
> +      ("gobject-introspection" ,gobject-introspection)
> +      ("pkg-config" ,pkg-config)))

The indentation of (native-inputs ...) is wrong.

> +   (inputs
> +    `(("json-glib" ,json-glib)

[...]

> +      ("brasero" ,brasero)))

Is Brasero an optional input?  It=E2=80=99s a CD burning application, which
seems unrelated to a music player.  Will Totem work even if Brasero is
not available at build time?  Or does it integrate more deeply with
Brasero?

> +   (description "Rhythmbox is a music playing application for GNOME. It =
supports
> +playlists, song ratings, and any codecs installed through
> gstreamer.")

Please use two spaces at the end of a sentence.

~~ Ricardo