From: Ricardo Wurmus <rekado@elephly.net>
To: David Hashe <david.hashe@dhashe.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add rhythmbox.
Date: Thu, 18 Jun 2015 15:45:55 +0200 [thread overview]
Message-ID: <87bngdi0z0.fsf@elephly.net> (raw)
In-Reply-To: <1434604057-17996-1-git-send-email-david.hashe@dhashe.com>
David Hashe <david.hashe@dhashe.com> writes:
> * gnu/packages/gnome.scm (rhythmbox): New variable.
[...]
> +(define-public rhythmbox
> + (package
> + (name "rhythmbox")
> + (version "3.2.1")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "mirror://gnome/sources/rhythmbox/3.2/"
Can you use (version-major+minor version) instead of “3.2” here?
> + "rhythmbox-" version ".tar.xz"))
> + (sha256
> + (base32
> + "0f3radhlji7rxl760yl2vm49fvfslympxrpm8497acbmbd7wlhxz"))))
> + (build-system glib-or-gtk-build-system)
> + (native-inputs
> + `(("intltool" ,intltool)
> + ("glib" ,glib "bin")
> + ("gobject-introspection" ,gobject-introspection)
> + ("pkg-config" ,pkg-config)))
The indentation of (native-inputs ...) is wrong.
> + (inputs
> + `(("json-glib" ,json-glib)
[...]
> + ("brasero" ,brasero)))
Is Brasero an optional input? It’s a CD burning application, which
seems unrelated to a music player. Will Totem work even if Brasero is
not available at build time? Or does it integrate more deeply with
Brasero?
> + (description "Rhythmbox is a music playing application for GNOME. It supports
> +playlists, song ratings, and any codecs installed through
> gstreamer.")
Please use two spaces at the end of a sentence.
~~ Ricardo
next prev parent reply other threads:[~2015-06-18 13:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 5:07 [PATCH] gnu: Add rhythmbox David Hashe
2015-06-18 13:45 ` Ricardo Wurmus [this message]
2015-06-19 2:09 ` David Hashe
2015-06-26 17:13 ` Ricardo Wurmus
2015-07-05 10:13 ` Ludovic Courtès
2015-07-05 11:44 ` Ricardo Wurmus
2015-07-05 15:28 ` David Hashe
2015-07-05 17:45 ` Amirouche Boubekki
2015-07-05 19:24 ` Amirouche Boubekki
2015-07-05 21:42 ` David Hashe
2015-07-06 19:34 ` Mark H Weaver
2015-07-07 3:39 ` David Hashe
2015-07-07 14:59 ` [PATCH] gnu: Add gst-plugins-ugly Mark H Weaver
2015-07-07 18:50 ` Mark H Weaver
2015-07-08 5:06 ` David Hashe
2015-07-08 18:16 ` Mark H Weaver
2015-07-10 5:17 ` Mark H Weaver
2015-07-12 19:42 ` David Hashe
2015-07-13 3:29 ` Mark H Weaver
2015-07-09 16:21 ` Mark H Weaver
2015-07-06 19:27 ` [PATCH] gnu: Add rhythmbox Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bngdi0z0.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=david.hashe@dhashe.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).