Re: [PATCH 2/3] gnu: Add python-blinker

[Christopher Allan Webber <cwebber@dustycloud.org>]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

Ludovic Courtès writes:

>> +    (inputs
>> +     `(("python-setuptools" ,python-setuptools)))
>
> Should be ‘native-inputs’ (it’s a build-time only dependency.)

Done!

>> +    (arguments '(#:tests? #f))
>
> Please add a comment explaining why.

Okay, I added one, I hope it's clear enough!

> Could you send an updated patch?

Yep, below!


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-python-blinker.patch --]
[-- Type: text/x-diff, Size: 2383 bytes --]

From 64f31f84f4691684a17b19d76f52b65c24f0232d Mon Sep 17 00:00:00 2001
From: Christopher Allan Webber <cwebber@dustycloud.org>
Date: Fri, 10 Jul 2015 16:12:47 -0500
Subject: [PATCH 1/2] gnu: Add python-blinker

* gnu/packages/python.scm (python-blinker python2-blinker): New variables.
---
 gnu/packages/python.scm | 33 ++++++++++++++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 4962a57..12d8c35 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -28,7 +28,7 @@
 (define-module (gnu packages python)
   #:use-module ((guix licenses)
                 #:select (asl2.0 bsd-4 bsd-3 bsd-2 non-copyleft cc0 x11 x11-style
-                          gpl2 gpl2+ gpl3+ lgpl2.0+ lgpl2.1 lgpl2.1+ lgpl3+
+                          gpl2 gpl2+ gpl3+ lgpl2.0+ lgpl2.1 lgpl2.1+ lgpl3+ agpl3
                           psfl public-domain x11-style))
   #:use-module ((guix licenses) #:select (expat zlib) #:prefix license:)
   #:use-module (gnu packages)
@@ -2154,6 +2154,37 @@ which can produce feeds in RSS 2.0, RSS 0.91, and Atom formats.")
 (define-public python2-feedgenerator
   (package-with-python2 python-feedgenerator))
 
+(define-public python-blinker
+  (package
+    (name "python-blinker")
+    (version "1.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://pypi.python.org/packages/source/b/blinker/blinker-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0bvfxkmjx6bpa302pv7v2vw5rwr3dlzjzfdp3bj628i6144024b8"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-setuptools" ,python-setuptools)))
+    ;; No "test" command supplied to setuptools, so unless there's another
+    ;; way to run tests, we're skipping them!
+    (arguments '(#:tests? #f))
+    (home-page "http://pythonhosted.org/blinker/")
+    (synopsis
+     "Fast, simple object-to-object and broadcast signaling")
+    (description
+     "Blinker provides a fast dispatching system that allows any number of
+interested parties to subscribe to events, or \"signals\".")
+    (license license:expat)))
+
+(define-public python2-blinker
+  (package-with-python2 python-blinker))
+
 (define-public python-scikit-learn
   (package
     (name "python-scikit-learn")
-- 
2.1.4