From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH] python2-ansible, python-ccm and dependencies
Date: Sat, 25 Jul 2015 12:07:40 +0200
Message-ID: <87bnf0y2hf.fsf@elephly.net>
References: <CAC9VnsKE1L-XaWmoNA2KjPC1KJ6HDEP25PrSdkBh=BSAFoOa2g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39786)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZIwMv-0002bb-Gx
	for guix-devel@gnu.org; Sat, 25 Jul 2015 06:07:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZIwMr-00054p-GT
	for guix-devel@gnu.org; Sat, 25 Jul 2015 06:07:49 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:25075)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZIwMr-000544-8U
	for guix-devel@gnu.org; Sat, 25 Jul 2015 06:07:45 -0400
In-reply-to: <CAC9VnsKE1L-XaWmoNA2KjPC1KJ6HDEP25PrSdkBh=BSAFoOa2g@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Dvorsak <yenda1@gmail.com>
Cc: guix-devel@gnu.org


Hi Eric,

> I added the following package definitions to python.scm :
>
> - python2-ansible
> - python-passlib
> - python-py-bcrypt
> - python-paramiko
> - python-httplib2
> - python-ecdsa
> - python-ccm

we normally make separate commits for separate packages.  The only
exception is for when we add python-<name> as well as python2-<name>;
they usually go together in the same commit.

Please also run ‘guix lint package-name’ for each of the new packages.
It will tell you a couple of things that you could do to improve.

One thing I noticed is that the description you provide for the packages
is the same as the synopsis.  The description, however, should provide
more information and it should be complete sentences (with
punctuation).

Things like ‘("python-setuptools" ,python-setuptools)’ are to be placed
in the list of ‘native-inputs’.  ‘native-inputs’ are only used at build
time.

Finally, there is no space between your definition of ‘python2-ccm’ and
the existing definition of ‘python-pytz’.

The other patch looks good to me, but it appears that this is a patch by
Mark Weaver.  Did you submit it by accident?

~~ Ricardo