From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/5] gnu: Add python-wrapt
Date: Sun, 13 Sep 2015 11:44:30 +0200
Message-ID: <87bnd68xhd.fsf@gnu.org>
References: <1441755264-6790-1-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41944)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zb3ps-0007dT-ID
	for guix-devel@gnu.org; Sun, 13 Sep 2015 05:44:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zb3pp-0005NY-4K
	for guix-devel@gnu.org; Sun, 13 Sep 2015 05:44:36 -0400
In-Reply-To: <1441755264-6790-1-git-send-email-tipecaml@gmail.com> (Cyril
	Roelandt's message of "Wed, 9 Sep 2015 01:34:20 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/python.scm (python-wrapt, python2-wrapt): New variables.

[...]

> +     ;; Lots of different test configurations. TODO: run them all.
> +     `(#:tests? #f))

It=E2=80=99s not clear why tests are not run.  Could you clarify this in the
comment?  (Or run them if there=E2=80=99s no particular reason not do it.)

> +    (synopsis
> +      "Module for decorators, wrappers and monkey patching")

One line is enough.

OK with these changes!

Thanks,
Ludo=E2=80=99.