unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Vicente Vera <vicentemvp@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 11/19] gnu: Add r-knitr.
Date: Mon, 14 Sep 2015 13:17:38 +0200	[thread overview]
Message-ID: <87bnd58d2l.fsf@mdc-berlin.de> (raw)
In-Reply-To: <CAMfbzvB_CjZtoKHGuGCs02HM7uC0MMXCeS2FvG36fzuM4AJHZg@mail.gmail.com>

Hi Vicente,

> From 36f94f07cba5edea4897ac36b92a73bfc6a3258b Mon Sep 17 00:00:00 2001
> From: Vicente Vera Parra <vicentemvp@gmail.com>
> Date: Sun, 13 Sep 2015 13:20:29 -0300
> Subject: [PATCH 11/19] gnu: Add r-knitr.

> * gnu/packages/statistics.scm (r-knitr): New variable.

[...]

> +    (synopsis "General-Purpose Package for Dynamic Report Generation in R")
> +    (description
> +     "Provides a general-purpose tool for dynamic report generation in
> +R using Literate Programming techniques.")

As before, please provide a better description (at least by replacing
“Provides” in the first sentence with “This package provides”); and use
lower-case in the synopsis.

> +    (license license:gpl3+)))

I don’t think this is correct.  The package actually doesn’t declare the
version of the GPL.  There are no license headers I could find and all
it says is

    “This package is free and open source software, licensed under GPL.”

Furthermore, as noted before, there might be a license conflict when
combining “r-knitr” with “r-markdown”, because the latter is released
under “GPLv2 only”.

I just asked the author about what version of the GPL was intended
here[1].

~~ Ricardo

[1]: https://github.com/yihui/knitr/issues/566#issuecomment-140042571

  reply	other threads:[~2015-09-14 11:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-13 16:51 [PATCH 11/19] gnu: Add r-knitr Vicente Vera
2015-09-14 11:17 ` Ricardo Wurmus [this message]
2015-09-14 20:06   ` Vicente Vera
2015-09-15 17:41     ` Vicente Vera
2015-09-16  9:51     ` Ricardo Wurmus
2015-09-22 15:08       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bnd58d2l.fsf@mdc-berlin.de \
    --to=ricardo.wurmus@mdc-berlin.de \
    --cc=guix-devel@gnu.org \
    --cc=vicentemvp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).