From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christopher Allan Webber <cwebber@dustycloud.org>
Subject: Re: [PATCH] gnu: guile: Add guile-irregex.
Date: Fri, 06 Nov 2015 10:58:58 -0600
Message-ID: <87bnb7dos5.fsf@dustycloud.org>
References: <87egg3dy0f.fsf@dustycloud.org> <874mgzjh15.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33612)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cwebber@dustycloud.org>) id 1ZukkY-0000NP-Ij
	for guix-devel@gnu.org; Fri, 06 Nov 2015 12:24:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cwebber@dustycloud.org>) id 1ZukkX-0007bV-PK
	for guix-devel@gnu.org; Fri, 06 Nov 2015 12:24:30 -0500
In-reply-to: <874mgzjh15.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>

Ludovic Court=C3=A8s writes:

> Christopher Allan Webber <cwebber@dustycloud.org> skribis:
>
>> On a side note, it would really be nice to have a
>> r6rs-build-system... starting to result in a lot of similar spaghetti =
in
>> a few of these packages.
>
> Is there really a standard R6 way of doing things?
>
> I agree some factorization would be welcome anyhow!

I don't really know, that comes from reading the Guildhall README:

  https://github.com/ijp/guildhall/blob/master/README

  > =3D=3D=3D Background =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
  > Guildhall is a port of Andreas Rottmanns Dorodango portable package m=
anager for
  > R6RS Scheme, adapted to better fit in with Guile Scheme environments.=
=20
  > It is compatible with the R6RS Scheme package archives that Dorodango=
 uses.
  >
  > dorodango is (intended to be) a package manager for R6RS
  > implementations. Its main concepts are outlined in this thread:
  > <http://groups.google.com/group/ikarus-users/browse_thread/thread/fab=
b890e3015f6f1>.

So I've thought there's something probably, but I haven't really looked
enough...

>> +     `(#:modules ((guix build utils)
>> +                  (ice-9 match)
>> +                  ,@%gnu-build-system-modules)
>
> I think (guix build gnu-build-system) is enough on the 3rd line.

Good call.

>> +    (synopsis "S-expression based regular expressions, packaged for G=
uile")
>
> I=E2=80=99d remove =E2=80=9C, packaged for Guile=E2=80=9D.
>
> Otherwise LGTM, thank you!
>
> Ludo=E2=80=99.

Done, and pushed!